From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH rdma-core 1/2] mlx5: Report if kernel allows using MPW in SQ
Date: Wed, 13 Sep 2017 12:38:49 -0600 [thread overview]
Message-ID: <20170913183849.GD1536@obsidianresearch.com> (raw)
In-Reply-To: <1bb5967f-45fd-fb22-7772-10bf6b35e2e1-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Tue, Sep 12, 2017 at 06:13:40PM +0300, Yishai Hadas wrote:
> On 9/11/2017 7:42 PM, Jason Gunthorpe wrote:
> >On Mon, Sep 11, 2017 at 02:43:04PM +0300, Yishai Hadas wrote:
> >> MLX5DV_CONTEXT_FLAGS_CQE_V1 = (1 << 0),
> >>- MLX5DV_CONTEXT_FLAGS_MPW = (1 << 1),
> >>+ MLX5DV_CONTEXT_FLAGS_MPW = (1 << 1), /* Obsoleted */
> >>+ MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED = (1 << 2),
> The bug was fixed in kernel 4.14 and now the feature is supported, the
> legacy value 1 on resp.support_multi_pkt_send_wqe is not reported from
> kernel any more as we can't rely on, and a new bit MLX5_ALLOW_MPW (1 << 1)
> was introduced to indicate that feature is supported.
That is very messy.. At least delete the MLX5DV_CONTEXT_FLAGS_MPW
constant to create a compile failure for this break.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-13 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 11:43 [PATCH rdma-core 0/2] Expose mlx5 multi packet capabilities Yishai Hadas
[not found] ` <1505130185-32658-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-09-11 11:43 ` [PATCH rdma-core 1/2] mlx5: Report if kernel allows using MPW in SQ Yishai Hadas
[not found] ` <1505130185-32658-2-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-09-11 16:42 ` Jason Gunthorpe
[not found] ` <20170911164257.GA2403-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-12 15:13 ` Yishai Hadas
[not found] ` <1bb5967f-45fd-fb22-7772-10bf6b35e2e1-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-09-13 18:38 ` Jason Gunthorpe [this message]
[not found] ` <20170913183849.GD1536-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-14 13:30 ` Yishai Hadas
2017-09-11 11:43 ` [PATCH rdma-core 2/2] mlx5: Report enhanced multi packet send WQE capability Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913183849.GD1536@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox