[PATCH] ibacm: Close MAD port when umad_register fails

[PATCH] ibacm: Close MAD port when umad_register fails

[Yuval Shaia]

Cleanup of the open port is needed when program fails to register MAD
port.

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 ibacm/src/acm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c
index aba0deaa..0c0da7e9 100644
--- a/ibacm/src/acm.c
+++ b/ibacm/src/acm.c
@@ -2418,8 +2418,10 @@ acm_open_port(struct acmc_port *port, struct acmc_device *dev, uint8_t port_num)
 
 	port->mad_agentid = umad_register(port->mad_portid,
 					  IB_MGMT_CLASS_SA, 1, 1, NULL);
-	if (port->mad_agentid < 0)
+	if (port->mad_agentid < 0) {
+		umad_close_port(port->mad_portid);
 		acm_log(0, "ERROR - unable to register MAD client\n");
+	}
 
 	port->prov = NULL;
 	port->state = IBV_PORT_DOWN;
-- 
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibacm: Close MAD port when umad_register fails

[Jason Gunthorpe]

On Tue, Sep 19, 2017 at 12:51:58AM +0300, Yuval Shaia wrote:
> Cleanup of the open port is needed when program fails to register MAD
> port.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>  ibacm/src/acm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Yuval, can you send this patch against rdma-core please? ibacm is not
longer separate.

https://github.com/linux-rdma/rdma-core

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibacm: Close MAD port when umad_register fails

[Yuval Shaia]

On Mon, Sep 18, 2017 at 03:55:47PM -0600, Jason Gunthorpe wrote:
> On Tue, Sep 19, 2017 at 12:51:58AM +0300, Yuval Shaia wrote:
> > Cleanup of the open port is needed when program fails to register MAD
> > port.
> > 
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >  ibacm/src/acm.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Yuval, can you send this patch against rdma-core please? ibacm is not
> longer separate.
> 
> https://github.com/linux-rdma/rdma-core

You mean as PR to rdma-core or just that subject should say rdma-core?
(or both?)

> 
> Thanks,
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibacm: Close MAD port when umad_register fails

[Jason Gunthorpe]

On Thu, Sep 21, 2017 at 01:30:30AM +0300, Yuval Shaia wrote:
> On Mon, Sep 18, 2017 at 03:55:47PM -0600, Jason Gunthorpe wrote:
> > On Tue, Sep 19, 2017 at 12:51:58AM +0300, Yuval Shaia wrote:
> > > Cleanup of the open port is needed when program fails to register MAD
> > > port.
> > > 
> > > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > >  ibacm/src/acm.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > Yuval, can you send this patch against rdma-core please? ibacm is not
> > longer separate.
> > 
> > https://github.com/linux-rdma/rdma-core
> 
> You mean as PR to rdma-core or just that subject should say rdma-core?
> (or both?)

Yes both/either will help it get picked up.

When I looked at the patch I wondered if it may have been against the
original pre-rdma-core ibacm tree, since it didn't mention rdma-core
or cc a rdma-core maintainer.... but I guess the ibacm/srcm/acm.c path
means it is against rdma-core, right?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibacm: Close MAD port when umad_register fails

[Yuval Shaia]

On Wed, Sep 20, 2017 at 04:50:12PM -0600, Jason Gunthorpe wrote:
> On Thu, Sep 21, 2017 at 01:30:30AM +0300, Yuval Shaia wrote:
> > On Mon, Sep 18, 2017 at 03:55:47PM -0600, Jason Gunthorpe wrote:
> > > On Tue, Sep 19, 2017 at 12:51:58AM +0300, Yuval Shaia wrote:
> > > > Cleanup of the open port is needed when program fails to register MAD
> > > > port.
> > > > 
> > > > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > > >  ibacm/src/acm.c | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > Yuval, can you send this patch against rdma-core please? ibacm is not
> > > longer separate.
> > > 
> > > https://github.com/linux-rdma/rdma-core
> > 
> > You mean as PR to rdma-core or just that subject should say rdma-core?
> > (or both?)
> 
> Yes both/either will help it get picked up.
> 
> When I looked at the patch I wondered if it may have been against the
> original pre-rdma-core ibacm tree, since it didn't mention rdma-core
> or cc a rdma-core maintainer.... but I guess the ibacm/srcm/acm.c path
> means it is against rdma-core, right?

Yes.

> 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html