* [PATCH rdma-core] ibacm: Close MAD port when umad_register fails
@ 2017-09-20 23:04 Yuval Shaia
[not found] ` <20170920230442.2334-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Shaia @ 2017-09-20 23:04 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA, leon-DgEjT+Ai2ygdnm+yROfE0A,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Yuval Shaia
Cleanup of the open port is needed when program fails to register MAD
port.
Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
ibacm/src/acm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c
index 367a43fe..1ccef948 100644
--- a/ibacm/src/acm.c
+++ b/ibacm/src/acm.c
@@ -2457,8 +2457,10 @@ acm_open_port(struct acmc_port *port, struct acmc_device *dev, uint8_t port_num)
port->mad_agentid = umad_register(port->mad_portid,
IB_MGMT_CLASS_SA, 1, 1, NULL);
- if (port->mad_agentid < 0)
+ if (port->mad_agentid < 0) {
+ umad_close_port(port->mad_portid);
acm_log(0, "ERROR - unable to register MAD client\n");
+ }
port->prov = NULL;
port->state = IBV_PORT_DOWN;
--
2.13.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-core] ibacm: Close MAD port when umad_register fails
[not found] ` <20170920230442.2334-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2017-09-21 13:18 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2017-09-21 13:18 UTC (permalink / raw)
To: Yuval Shaia
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Thu, Sep 21, 2017 at 02:04:42AM +0300, Yuval Shaia wrote:
> Cleanup of the open port is needed when program fails to register MAD
> port.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> ibacm/src/acm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Thanks, applied.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 23:04 [PATCH rdma-core] ibacm: Close MAD port when umad_register fails Yuval Shaia
[not found] ` <20170920230442.2334-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-21 13:18 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox