From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 04/10] providers: Use the new match_device and allocate_device ops Date: Sun, 24 Sep 2017 14:10:53 -0600 Message-ID: <20170924201053.GA31652@obsidianresearch.com> References: <1505855931-4956-1-git-send-email-jgunthorpe@obsidianresearch.com> <1505855931-4956-5-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Amrani, Ram" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Devesh Sharma , Steve Wise , Mike Marciniszyn , Dennis Dalessandro , Lijun Ou , "Wei Hu(Xavier)" , Tatyana Nikolova , Yishai Hadas , Vladimir Sokolovsky , "Elior, Ariel" , Moni Shoua , Adit Ranadive , "moderated list:HF1 USERSPACE PROVIDER (for hf1.ko)" , "open list:IPATH/QIB USERSPACE PROVIDER (for ib_qib.ko)" , "pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Sun, Sep 24, 2017 at 01:44:58PM +0000, Amrani, Ram wrote: > Please use qelr_ prefix for the functions. > There shouldn't be any qedr in this file except for a comment, maybe. I changed the series like so: diff --git a/providers/qedr/qelr_main.c b/providers/qedr/qelr_main.c index 1297e8e16acee5..fa2be455edc93e 100644 --- a/providers/qedr/qelr_main.c +++ b/providers/qedr/qelr_main.c @@ -223,7 +223,7 @@ static void qelr_free_context(struct ibv_context *ibctx) free(ctx); } -static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev) +static struct verbs_device *qelr_device_alloc(struct verbs_sysfs_dev *sysfs_dev) { struct qelr_device *dev; @@ -235,11 +235,11 @@ static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev) } static const struct verbs_device_ops qelr_dev_ops = { - .name = "qelr", + .name = "qedr", .match_min_abi_version = QELR_ABI_VERSION, .match_max_abi_version = QELR_ABI_VERSION, .match_table = hca_table, - .alloc_device = qedr_device_alloc, + .alloc_device = qelr_device_alloc, .uninit_device = qelr_uninit_device, .alloc_context = qelr_alloc_context, .free_context = qelr_free_context, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html