Re: [PATCH] IB/{ipoib,iser}: Consistent print format of vendor error

Yuval Shaia
2017-09-26T07:02:07Z

On Wed, Sep 06, 2017 at 01:20:25PM +0300, Sagi Grimberg wrote:
>
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > index 14b62f7472b4..fd302ba78869 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > @@ -594,9 +594,9 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
> > skb = rx_ring[wr_id].skb;
> > if (unlikely(wc->status != IB_WC_SUCCESS)) {
> > - ipoib_dbg(priv, "cm recv error "
> > - "(status=%d, wrid=%d vend_err %x)\n",
> > - wc->status, wr_id, wc->vendor_err);
> > + ipoib_dbg(priv,
> > + "cm recv error (status=%d, wrid=%d vend_err 0x%x)\n",
>
> %#x would be better Yuval,

Thanks,
Please check v1.

>
> otherwise looks fine,
>
> Acked-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html