Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

Leon Romanovsky
2017-09-26T08:38:43Z

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote:
> pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
> avoid other messages being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Did you see it is happening?
It is not needed after 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")

Thanks.

>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 0e2789d..92d643a 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
> mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont,
> page_shift, order, access_flags);
> if (PTR_ERR(mr) == -EAGAIN) {
> - mlx5_ib_dbg(dev, "cache empty for order %d", order);
> + mlx5_ib_dbg(dev, "cache empty for order %d\n", order);
> mr = NULL;
> }
> } else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) {
> if (access_flags & IB_ACCESS_ON_DEMAND) {
> err = -EINVAL;
> - pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB");
> + pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n");
> goto error;
> }
> use_umr = false;
> --
> 1.9.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]