From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/ipoib: Enable pkey and device name decoupling Date: Thu, 28 Sep 2017 10:38:24 -0600 Message-ID: <20170928163824.GC17880@obsidianresearch.com> References: <20170927093248.3819-1-yuval.shaia@oracle.com> <20170927150140.GF2297@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mukesh Kacker Cc: Leon Romanovsky , Yuval Shaia , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kernel-6AxghH7DbtA@public.gmane.org, ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, shamir.rabinovitch-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, chien.yen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Sep 27, 2017 at 12:03:40PM -0700, Mukesh Kacker wrote: > Having devices with names like ib0.datanet, ib1.cellnet or any other > ib. simplifies that life of people designing the management tools > for networks and integrating them for the use case of renumbering of pkeys. You should already be able to rename ipoib devices via 'ip link set name' - why didn't you use that to get your names? Do you need atomicity for some reason?? > variant if it requires using device name with pkey values at any stage in > the use case. Same for delete_named_child. delete_named_child is ugly, it should be a netlink command, and it should use a ifindex, not name. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html