From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vishwanathapura, Niranjana" Subject: Re: [PATCH for-next 0/2] IB/opa_vnic: Add debugfs interface Date: Thu, 28 Sep 2017 12:05:02 -0700 Message-ID: <20170928190502.GA33289@knc-06.sc.intel.com> References: <20170926140714.18110.74689.stgit@scvm10.sc.intel.com> <20170926174946.GA1218@mtr-leonro.local> <20170926175524.GA2297@mtr-leonro.local> <20170926181214.GA41364@knc-06.sc.intel.com> <1506525977.33755.3.camel@redhat.com> <20170928184727.GA33282@knc-06.sc.intel.com> <20170928185753.GG2297@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20170928185753.GG2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , Dennis Dalessandro , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sudeep Dutt , Sadanand Warrier List-Id: linux-rdma@vger.kernel.org On Thu, Sep 28, 2017 at 09:57:53PM +0300, Leon Romanovsky wrote: >On Thu, Sep 28, 2017 at 11:47:28AM -0700, Vishwanathapura, Niranjana wrote: >> On Wed, Sep 27, 2017 at 11:26:17AM -0400, Doug Ledford wrote: >> > On Tue, 2017-09-26 at 11:12 -0700, Vishwanathapura, Niranjana wrote: >> > > The debugfs interface here is for VNIC port encapsulation >> > > configuration. >> > > They are not related to netdevice functionality. >> > > >> > > They are for debug purpose only and not the supported configuration >> > > mechanism. >> > >> > OK, if this isn't the supported configuration mechanism, then what is >> > the supported mechanism? >> > >> >> The supported mechanism is the Ethernet Manager providing the encapsulation >> configuration (as in the opa_vnic.txt documentation) >> This is just a debug interface to it. > >Add tracepoint for that. > For some reason, I couldn't find Leon's earlier response on my mutt! Will repond here. It is not really for tracing, but to have a simple debug read/write access to the encapsution configuration which allows us to triage issues. We find it useful on an ongoing basis, more like some standard NICs providing debugfs interface to read/write from/to some of its registers. It is much easier to have it upstreamed and available instead of maintaining these patches separately. Niranjana >> >> Niranjana >> >> > -- >Doug Ledford >> > GPG KeyID: B826A3330E572FDD >> > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD >> > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html