Re: [PATCH for-next 0/2] IB/opa_vnic: Add debugfs interface

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]

On Thu, Sep 28, 2017 at 12:05:02PM -0700, Vishwanathapura, Niranjana wrote:
> On Thu, Sep 28, 2017 at 09:57:53PM +0300, Leon Romanovsky wrote:
> > On Thu, Sep 28, 2017 at 11:47:28AM -0700, Vishwanathapura, Niranjana wrote:
> > > On Wed, Sep 27, 2017 at 11:26:17AM -0400, Doug Ledford wrote:
> > > > On Tue, 2017-09-26 at 11:12 -0700, Vishwanathapura, Niranjana wrote:
> > > > > The debugfs interface here is for VNIC port encapsulation
> > > > > configuration.
> > > > > They are not related to netdevice functionality.
> > > > >
> > > > > They are for debug purpose only and not the supported configuration
> > > > > mechanism.
> > > >
> > > > OK, if this isn't the supported configuration mechanism, then what is
> > > > the supported mechanism?
> > > >
> > >
> > > The supported mechanism is the Ethernet Manager providing the encapsulation
> > > configuration (as in the opa_vnic.txt documentation)
> > > This is just a debug interface to it.
> >
> > Add tracepoint for that.
> >
>
> For some reason, I couldn't find Leon's earlier response on my mutt! Will
> repond here.
>
> It is not really for tracing, but to have a simple debug read/write access
> to the encapsution configuration which allows us to triage issues.
>
> We find it useful on an ongoing basis, more like some standard NICs
> providing debugfs interface to read/write from/to some of its registers.

Usually if such interface is spotted during submission, it will be requested
to drop it. Ask Salil, who lately upstreamed new ETH driver and was asked
to remove it.

>
> It is much easier to have it upstreamed and available instead of maintaining
> these patches separately.

See, I didn't hear anyone here against adding such ability, but if you
want to hear such, you can always CC netdev :).

The question, we are asking is related to the interface chosen to do so - debugfs, and IMHO it is a mistake.

Thanks

>
> Niranjana
>
> > >
> > > Niranjana
> > >
> > > > -- >Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > >    GPG KeyID: B826A3330E572FDD
> > > >    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
> > > >
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]