public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Vishwanathapura, Niranjana" <niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Dennis Dalessandro
	<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sudeep Dutt <sudeep.dutt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Sadanand Warrier
	<sadanand.warrier-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH for-next 0/2] IB/opa_vnic: Add debugfs interface
Date: Fri, 29 Sep 2017 08:27:08 -0700	[thread overview]
Message-ID: <20170929152707.GA34521@knc-06.sc.intel.com> (raw)
In-Reply-To: <20170929145950.GC2965-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>

On Fri, Sep 29, 2017 at 05:59:50PM +0300, Leon Romanovsky wrote:
>On Fri, Sep 29, 2017 at 10:46:51AM -0400, Dennis Dalessandro wrote:
>>
>> All of this vnic stuff is a work in progress and we are incrementally
>> pushing things out. Iterative development, involving the community and all.
>
>Can we get OPA-VNIC specification? Can we get OPA specification?
>
>The Documentation/infiniband/opa_vnic.txt is not enough to really
>implement anything on top of that or communicate with that.
>
>For example, what are the values and relations for routing control? How
>is entropy calculated?
>

You are putting a wrong interpretation to this patch.
EM provides the encapsulation configuration as in the opa_vnic documentation.
EM will be opensourced when it is ready (VNIC is development in progress).

As mentioned, this patch is a simple *debug* hook to that encapsulation 
configuration and no more.
That is why it is put under DEBUGFS.

I do see valid reason in Jason's and your earlier comments that it should a 
formal support to the admins.
But this patch was not mainly for that. I don't expect DEBUGFS to be turned on 
in all deployments.
I understand the question whether or not this patch should be in the kernel 
tree.
But it is a useful debug hook for debugging/triaging issues (similar to NIC 
having debug hook read/write some register), and convenient to have it 
available in the kernel than maintaining it separately.

Niranjana

>Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-09-29 15:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26 14:08 [PATCH for-next 0/2] IB/opa_vnic: Add debugfs interface Dennis Dalessandro
     [not found] ` <20170926140714.18110.74689.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-09-26 14:08   ` [PATCH for-next 1/2] IB/opa_vnic: Add debugfs support to OPA VNIC Dennis Dalessandro
2017-09-26 14:08   ` [PATCH for-next 2/2] IB/opa_vnic: Support adding OPA VNIC vports through debug interface Dennis Dalessandro
2017-09-26 17:49   ` [PATCH for-next 0/2] IB/opa_vnic: Add debugfs interface Leon Romanovsky
     [not found]     ` <20170926174946.GA1218-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-26 17:55       ` Leon Romanovsky
     [not found]         ` <20170926175524.GA2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-26 18:12           ` Vishwanathapura, Niranjana
     [not found]             ` <20170926181214.GA41364-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-09-27  6:20               ` Leon Romanovsky
2017-09-27 15:26               ` Doug Ledford
     [not found]                 ` <1506525977.33755.3.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-28 18:47                   ` Vishwanathapura, Niranjana
     [not found]                     ` <20170928184727.GA33282-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-09-28 18:57                       ` Leon Romanovsky
     [not found]                         ` <20170928185753.GG2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28 19:05                           ` Vishwanathapura, Niranjana
     [not found]                             ` <20170928190502.GA33289-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-09-28 19:37                               ` Leon Romanovsky
     [not found]                                 ` <20170928193740.GH2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28 20:02                                   ` Jason Gunthorpe
     [not found]                                     ` <20170928200258.GA27343-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-29  5:49                                       ` Leon Romanovsky
     [not found]                                         ` <20170929054959.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-29 14:46                                           ` Dennis Dalessandro
     [not found]                                             ` <cbb65789-2d1e-779e-77f8-55b435511069-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-29 14:59                                               ` Leon Romanovsky
     [not found]                                                 ` <20170929145950.GC2965-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-29 15:27                                                   ` Vishwanathapura, Niranjana [this message]
     [not found]                                                     ` <20170929152707.GA34521-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-10-02  4:23                                                       ` Leon Romanovsky
     [not found]                                                         ` <20171002042323.GG2031-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-03  0:47                                                           ` Dennis Dalessandro
     [not found]                                                             ` <68a08a10-5b8d-4fd7-ad06-8add423bd3cd-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-03  5:15                                                               ` Leon Romanovsky
     [not found]                                                                 ` <20171003051521.GA26055-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-03 17:05                                                                   ` Vishwanathapura, Niranjana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929152707.GA34521@knc-06.sc.intel.com \
    --to=niranjana.vishwanathapura-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sadanand.warrier-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=sudeep.dutt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox