librdmacm in rdma-core build warnings

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

Hi All,

After moving to gcc version 7.2.0 (GCC), I started experience the
following compilation warning with default build.sh supplied with
rdma-core.

[26/189] Building C object librdmacm/CMakeFiles/rspreload.dir/preload.c.o
../librdmacm/preload.c:818:9: warning: no previous prototype for ‘readv’ [-Wmissing-prototypes]
 ssize_t readv(int socket, const struct iovec *iov, int iovcnt)
         ^~~~~
../librdmacm/preload.c:857:9: warning: no previous prototype for ‘writev’ [-Wmissing-prototypes]
 ssize_t writev(int socket, const struct iovec *iov, int iovcnt)

The code to enable -Wmissing-prototypes checks is part of the rdma-core
for a year now, see commit: b192ed2347e5 ("Enable -Wmissing-prototypes/-Wmissing-declarations")

The fact that librdmacm/preload.c uses combination of RTLD_NEXT and
dlsym to set readv/writev scares me to just delete readv and writev calls,
because it is most probably wrong.

Any ideas how to fix it?

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]