From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Clark Williams <williams@redhat.com>,
Dean Luick <dean.luick@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
Kaike Wan <kaike.wan@intel.com>,
Leon Romanovsky <leonro@mellanox.com>,
linux-rdma@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Sebastian Sanchez <sebastian.sanchez@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()
Date: Thu, 5 Oct 2017 18:30:19 +0200 [thread overview]
Message-ID: <20171005163018.tk73i2vr2thaj2pn@linutronix.de> (raw)
In-Reply-To: <20171003154920.31566-2-acme@kernel.org>
On 2017-10-03 12:49:19 [-0300], Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c
> index 615be68e40b3..3a30bde9a07b 100644
> --- a/drivers/infiniband/hw/hfi1/pio.c
> +++ b/drivers/infiniband/hw/hfi1/pio.c
> @@ -1421,7 +1421,7 @@ struct pio_buf *sc_buffer_alloc(struct send_context *sc, u32 dw_len,
>
> /* there is enough room */
>
> - preempt_disable();
> + preempt_disable_nort();
> this_cpu_inc(*sc->buffers_allocated);
>
> /* read this once */
please replace the preempt_disable() / enable with local_lock() /
unlock. The section does not look like it could cope with multiple users
dereferencing / using the same per-CPU variables.
Sebastian
next prev parent reply other threads:[~2017-10-05 16:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:49 [GIT PULL 0/2] infiniband hfi1 PREEMPT_RT_FULL changes Arnaldo Carvalho de Melo
2017-10-03 15:49 ` [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort() Arnaldo Carvalho de Melo
2017-10-05 14:17 ` Julia Cartwright
[not found] ` <20171005141744.GC21185-ew3lsbMjNqt5wtABiV/Xjqyly8cj88Ttqxv4g6HH51o@public.gmane.org>
2017-10-05 15:27 ` Thomas Gleixner
2017-10-05 15:37 ` Julia Cartwright
[not found] ` <20171005153759.GG647-ew3lsbMjNqt5wtABiV/Xjqyly8cj88Ttqxv4g6HH51o@public.gmane.org>
2017-10-05 15:55 ` Steven Rostedt
2017-10-05 16:05 ` Julia Cartwright
2017-10-05 16:16 ` Thomas Gleixner
2017-10-05 16:39 ` Julia Cartwright
2017-10-05 16:53 ` Arnaldo Carvalho de Melo
2017-10-05 18:29 ` Julia Cartwright
[not found] ` <20171005182900.GK647-ew3lsbMjNqt5wtABiV/Xjqyly8cj88Ttqxv4g6HH51o@public.gmane.org>
2017-10-05 18:53 ` Arnaldo Carvalho de Melo
2017-10-05 19:15 ` Steven Rostedt
2017-10-05 16:30 ` Sebastian Andrzej Siewior [this message]
2017-10-06 9:19 ` Sebastian Andrzej Siewior
[not found] ` <20171003154920.31566-2-acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-10 18:59 ` Dennis Dalessandro
[not found] ` <1d06a3da-426f-c887-1da7-64b760c53425-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-10 19:02 ` Arnaldo Carvalho de Melo
[not found] ` <20171010190218.GN28623-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-11 11:03 ` Sebastian Andrzej Siewior
2017-10-11 13:43 ` Arnaldo Carvalho de Melo
2017-10-03 15:49 ` [PATCH 2/2] IB/hfi1: Handle packets in the theaded handler only Arnaldo Carvalho de Melo
2017-10-05 16:27 ` Sebastian Andrzej Siewior
2017-10-10 19:06 ` Dennis Dalessandro
2017-10-10 19:15 ` Arnaldo Carvalho de Melo
2017-10-11 10:44 ` Sebastian Andrzej Siewior
2017-10-11 13:42 ` Arnaldo Carvalho de Melo
[not found] ` <20171011104456.mlewocqc6ghi3fev-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2017-10-11 19:07 ` Arnaldo Carvalho de Melo
2017-10-11 19:14 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005163018.tk73i2vr2thaj2pn@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=dean.luick@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=kaike.wan@intel.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sebastian.sanchez@intel.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).