From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH rdma-core] librdmacm: Fix compilation warnings
Date: Sun, 8 Oct 2017 08:36:41 +0300 [thread overview]
Message-ID: <20171008053641.GM25829@mtr-leonro.local> (raw)
In-Reply-To: <20171003110529.25635-1-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
On Tue, Oct 03, 2017 at 02:05:29PM +0300, Leon Romanovsky wrote:
> Combination of glibc 2.26-4 and gcc 7.2.0-3 produces of following
> warnings at the compilation phase of rdma-core.
>
> [24/189] Building C object librdmacm/CMakeFiles/rspreload.dir/preload.c.o
> ../librdmacm/preload.c:818:9: warning: no previous prototype for ‘readv’ [-Wmissing-prototypes]
> ssize_t readv(int socket, const struct iovec *iov, int iovcnt)
> ^~~~~
> ../librdmacm/preload.c:857:9: warning: no previous prototype for ‘writev’ [-Wmissing-prototypes]
> ssize_t writev(int socket, const struct iovec *iov, int iovcnt)
>
> The simple addition of "sys/uio.h" proposed by Sean Hefty [1] with Jason
> Gunthrope support [2] fixes it.
>
> [1] https://marc.info/?l=linux-rdma&m=150696066510225&w=2
> [2] https://marc.info/?l=linux-rdma&m=150696688111945&w=2
> Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> librdmacm/preload.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Thanks, applied.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-08 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 11:05 [PATCH rdma-core] librdmacm: Fix compilation warnings Leon Romanovsky
[not found] ` <20171003110529.25635-1-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-08 5:36 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171008053641.GM25829@mtr-leonro.local \
--to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox