From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Nelio Laranjeiro
<nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
Adrien Mazarguil
<adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH rdma-core] verbs: Fix C++ compilation break
Date: Mon, 9 Oct 2017 13:11:01 -0600 [thread overview]
Message-ID: <20171009191101.GC15336@obsidianresearch.com> (raw)
In-Reply-To: <20171009190519.GD1252-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Mon, Oct 09, 2017 at 10:05:19PM +0300, Leon Romanovsky wrote:
> It means that your glibc is new enough.
> On some systems, the stdint.h contains the following ifdef to protect UINTPTR_MAX
> "#if !defined __cplusplus || defined __STDC_LIMIT_MACROS"
Ah, that old thing. __STDC_LIMIT_MACROS is removed from the latest
standards, and IIRC, including cstdint isn't even enough to reliably
get the macros under the old standards.
The commit comment should describe the problem in these terms..
So this is the best fix:
> > #ifdef __cplusplus
> > #include <limits>
> > #define __VERBS_ABI_IS_EXTENDED ((void *)std::numeric_limits<uintptr_t>::max())
> > #else
> > #define __VERBS_ABI_IS_EXTENDED ((void *)UINTPTR_MAX)
> > #endif
Because numeric_limits is never subject to __STDC_LIMIT_MACROS
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-09 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 8:17 [PATCH rdma-core] verbs: Fix C++ compilation break Leon Romanovsky
[not found] ` <20171009081717.21478-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-09 13:12 ` Nicolas Morey-Chaisemartin
[not found] ` <537d72a7-19c3-d13d-4b49-538744a73845-l3A5Bk7waGM@public.gmane.org>
2017-10-09 13:38 ` Leon Romanovsky
2017-10-09 15:41 ` Jason Gunthorpe
[not found] ` <20171009154104.GA3824-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-09 19:05 ` Leon Romanovsky
[not found] ` <20171009190519.GD1252-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-09 19:11 ` Jason Gunthorpe [this message]
[not found] ` <20171009191101.GC15336-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-09 19:33 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009191101.GC15336@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox