RE: [PATCH rdma-core] iwpmd: Return existing mapping if port reused on active side

Steve Wise
2017-10-10T17:24:19Z

>
> On Sun, Oct 08, 2017 at 06:34:28PM -0500, Tatyana Nikolova wrote:
> > From: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > Port-mapper returns a duplicate mapping error and no
> > mapped port if an attempt is made to add a mapping for
> > a new connection which re-uses the local port on active side.
> > Fix this by finding the existing mapping for the re-used
> > local port and return the mapped port. Also, change ref_cnt
> > in struct iwpm_port to be atomic and use it to track the
> > references to a mapping.
> >
> > Signed-off-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > iwpmd/iwarp_pm.h | 5 ++---
> > iwpmd/iwarp_pm_helper.c | 27 ++++-----------------------
> > iwpmd/iwarp_pm_server.c | 47
+++++++++++++++++++++--------------------------
> > 3 files changed, 27 insertions(+), 52 deletions(-)
> >
>
> Any feedback from iWARP crowd?
>

Yes.

How is a new connection re-using the local port exactly? Is there a test case
that reproduces this?

Other than that,

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>