From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 42/47] IB/qib: Remove set-but-not-used variables
Date: Thu, 12 Oct 2017 18:54:04 +0300 [thread overview]
Message-ID: <20171012155404.GR2106@mtr-leonro.local> (raw)
In-Reply-To: <1507823130.2448.16.camel-Sjgp3cTcYWE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Thu, Oct 12, 2017 at 03:45:31PM +0000, Bart Van Assche wrote:
> On Thu, 2017-10-12 at 11:44 +0300, Leon Romanovsky wrote:
> > I'm running more or less the same checks ( + "CHECK=sparse C=2") and for
> > a long time I'm trying to fix nes and orcdma endianess errors, but
> > without much luck. Did you look on them and plan to address in near
> > future?
>
> Hello Leon,
>
> My experience is that for some drivers, e.g. drivers/scsi/qla2xxx, making
> these endianness clean is a huge task. I prefer that the driver authors work
> on this. I have been using the following patch to suppress complaints about
> endianness issues for drivers that are not endianness clean:
> https://lkml.org/lkml/2017/10/6/638.
Thanks, I'll try your approach.
>
> Bart.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-12 15:54 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 21:32 [PATCH 00/47] Address issues detected by static analysis tools Bart Van Assche
[not found] ` <20171006213333.6721-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 21:32 ` [PATCH 01/47] IB/core: Fix endianness annotation in rdma_is_multicast_addr() Bart Van Assche
[not found] ` <20171006213333.6721-2-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:50 ` Leon Romanovsky
2017-10-06 21:32 ` [PATCH 02/47] IB/cm: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-3-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:03 ` Hefty, Sean
2017-10-10 19:27 ` Dennis Dalessandro
[not found] ` <849d304a-fa89-0d6a-6edb-cf34780e41a8-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-10 19:29 ` Hefty, Sean
2017-10-10 19:31 ` Leon Romanovsky
[not found] ` <20171010193127.GK2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 19:49 ` Dennis Dalessandro
2017-10-06 21:32 ` [PATCH 03/47] RDMA/cma: Avoid triggering undefined behavior Bart Van Assche
[not found] ` <20171006213333.6721-4-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:01 ` Hefty, Sean
2017-10-06 21:32 ` [PATCH 04/47] RDMA/iwcm: Remove a set-but-not-used variable Bart Van Assche
[not found] ` <20171006213333.6721-5-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:05 ` Steve Wise
2017-10-06 21:32 ` [PATCH 05/47] RDMA/uverbs: Make the code in ib_uverbs_cmd_verbs() less confusing Bart Van Assche
[not found] ` <20171006213333.6721-6-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 7:40 ` Matan Barak (External)
[not found] ` <64b5f415-7d56-3f17-0c8c-5d80ba89582c-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-09 17:27 ` Bart Van Assche
[not found] ` <1507570048.2674.17.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 5:19 ` Matan Barak
[not found] ` <3a6adf24-3e60-7fd1-a119-37586793d374-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-11 15:30 ` Bart Van Assche
[not found] ` <1507735840.2477.8.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-15 7:37 ` Matan Barak
2017-10-06 21:32 ` [PATCH 06/47] RDMA/isert: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-7-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:10 ` Sagi Grimberg
2017-10-06 21:32 ` [PATCH 07/47] RDMA/bnxt_re: " Bart Van Assche
2017-10-06 21:32 ` [PATCH 08/47] RDMA/bnxt_re: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:32 ` [PATCH 09/47] RDMA/cxgb3: Annotate locking assumptions Bart Van Assche
[not found] ` <20171006213333.6721-10-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:05 ` Steve Wise
2017-10-06 21:32 ` [PATCH 10/47] RDMA/cxgb3: Annotate an RCU pointer Bart Van Assche
[not found] ` <20171006213333.6721-11-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:06 ` Steve Wise
2017-10-06 21:32 ` [PATCH 11/47] RDMA/cxgb3: Remove a set-but-not-used variable Bart Van Assche
[not found] ` <20171006213333.6721-12-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:06 ` Steve Wise
2017-10-06 21:32 ` [PATCH 12/47] RDMA/cxgb4: Fix indentation Bart Van Assche
[not found] ` <20171006213333.6721-13-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:10 ` Steve Wise
2017-10-06 21:32 ` [PATCH 13/47] RDMA/cxgb4: Declare a local variable 'static' Bart Van Assche
[not found] ` <20171006213333.6721-14-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:09 ` Steve Wise
2017-10-09 23:20 ` Bart Van Assche
[not found] ` <1507591219.2674.58.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 3:59 ` Leon Romanovsky
[not found] ` <20171010035909.GI1252-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 16:16 ` Bart Van Assche
2017-10-06 21:33 ` [PATCH 14/47] RDMA/cxgb4: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-15-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:08 ` Steve Wise
2017-10-06 21:33 ` [PATCH 15/47] RDMA/cxgb4: Remove a set-but-not-used variable Bart Van Assche
[not found] ` <20171006213333.6721-16-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:07 ` Steve Wise
2017-10-06 21:33 ` [PATCH 16/47] IB/hfi1: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-17-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 19:50 ` Dennis Dalessandro
2017-10-06 21:33 ` [PATCH 17/47] IB/hfi1: Remove set-but-not-used variables Bart Van Assche
[not found] ` <20171006213333.6721-18-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:45 ` Dennis Dalessandro
2017-10-06 21:33 ` [PATCH 18/47] IB/hfi1: Define hfi1_handle_cnp_tbl[] once Bart Van Assche
[not found] ` <20171006213333.6721-19-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:54 ` Dennis Dalessandro
2017-10-06 21:33 ` [PATCH 19/47] IB/hns: Annotate iomem pointers correctly Bart Van Assche
[not found] ` <20171006213333.6721-20-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:42 ` Leon Romanovsky
[not found] ` <20171008134219.GB25829-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-09 17:10 ` Bart Van Assche
2017-10-06 21:33 ` [PATCH 20/47] IB/hns: Declare local functions 'static' Bart Van Assche
[not found] ` <20171006213333.6721-21-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:44 ` Leon Romanovsky
2017-10-06 21:33 ` [PATCH 21/47] RDMA/i40iw: Fix a race condition Bart Van Assche
[not found] ` <20171006213333.6721-22-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:04 ` Shiraz Saleem
2017-10-06 21:33 ` [PATCH 22/47] RDMA/i40iw: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-23-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:04 ` Shiraz Saleem
2017-10-06 21:33 ` [PATCH 23/47] RDMA/i40iw: Remove a set-but-not-used variable Bart Van Assche
[not found] ` <20171006213333.6721-24-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:05 ` Shiraz Saleem
2017-10-06 21:33 ` [PATCH 24/47] IB/mthca: Fix indentation Bart Van Assche
2017-10-06 21:33 ` [PATCH 25/47] IB/mlx4: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-26-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 7:50 ` Leon Romanovsky
2017-10-06 21:33 ` [PATCH 26/47] IB/mlx5: " Bart Van Assche
[not found] ` <20171006213333.6721-27-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 7:55 ` Leon Romanovsky
2017-10-06 21:33 ` [PATCH 27/47] IB/mlx5: Remove a set-but-not-used variable Bart Van Assche
[not found] ` <20171006213333.6721-28-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 7:55 ` Leon Romanovsky
2017-10-06 21:33 ` [PATCH 28/47] IB/nes: Fix indentation Bart Van Assche
2017-10-06 21:33 ` [PATCH 29/47] IB/nes: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-06 21:33 ` [PATCH 30/47] IB/nes: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33 ` [PATCH 31/47] IB/nes: Fix a race condition in nes_inetaddr_event() Bart Van Assche
2017-10-06 21:33 ` [PATCH 32/47] RDMA/ocrdma: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-06 21:33 ` [PATCH 33/47] RDMA/ocrdma: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-06 21:33 ` [PATCH 34/47] RDMA/ocrdma: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33 ` [PATCH 35/47] IB/opa: Fix endianness annotation of opa_is_extended_lid() Bart Van Assche
[not found] ` <20171006213333.6721-36-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:59 ` Dennis Dalessandro
2017-10-06 21:33 ` [PATCH 36/47] RDMA/qedr: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-06 21:33 ` [PATCH 37/47] RDMA/qedr: Declare local functions static Bart Van Assche
2017-10-06 21:33 ` [PATCH 38/47] RDMA/qedr: Annotate iomem pointers correctly Bart Van Assche
2017-10-06 21:33 ` [PATCH 39/47] RDMA/qedr: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33 ` [PATCH 40/47] IB/qib: Make qib_inc_eeprom_err() macro more safe to use Bart Van Assche
[not found] ` <20171006213333.6721-41-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 14:15 ` Marciniszyn, Mike
[not found] ` <32E1700B9017364D9B60AED9960492BC3442AAD2-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 15:08 ` Bart Van Assche
[not found] ` <1507648081.2815.5.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 15:36 ` Marciniszyn, Mike
[not found] ` <32E1700B9017364D9B60AED9960492BC3442ADF5-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 17:59 ` Bart Van Assche
[not found] ` <1507658390.2815.48.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 18:08 ` Leon Romanovsky
[not found] ` <20171010180809.GI2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 18:25 ` Bart Van Assche
[not found] ` <1507659918.2815.50.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 18:33 ` Leon Romanovsky
2017-10-10 20:40 ` Marciniszyn, Mike
2017-10-06 21:33 ` [PATCH 41/47] IB/qib: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-42-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 13:56 ` Marciniszyn, Mike
[not found] ` <32E1700B9017364D9B60AED9960492BC3442AA1D-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 15:07 ` Bart Van Assche
2017-10-06 21:33 ` [PATCH 42/47] IB/qib: Remove set-but-not-used variables Bart Van Assche
[not found] ` <20171006213333.6721-43-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 20:25 ` Marciniszyn, Mike
[not found] ` <32E1700B9017364D9B60AED9960492BC3442B95A-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 20:40 ` Bart Van Assche
[not found] ` <1507668036.2815.55.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-12 8:44 ` Leon Romanovsky
[not found] ` <20171012084412.GO2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-12 15:45 ` Bart Van Assche
[not found] ` <1507823130.2448.16.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-12 15:54 ` Leon Romanovsky [this message]
2017-10-06 21:33 ` [PATCH 43/47] RDMA/rdmavt: Suppress gcc 7 fall-through complaints Bart Van Assche
[not found] ` <20171006213333.6721-44-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 19:51 ` Dennis Dalessandro
2017-10-06 21:33 ` [PATCH 44/47] RDMA/rxe: " Bart Van Assche
[not found] ` <20171006213333.6721-45-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:45 ` Leon Romanovsky
2017-10-06 21:33 ` [PATCH 45/47] RDMA/usnic: Make the compiler check declaration consistency during compilation Bart Van Assche
2017-10-06 21:33 ` [PATCH 46/47] RDMA/usnic: Remove a set-but-not-used variable Bart Van Assche
2017-10-06 21:33 ` [PATCH 47/47] RDMA/usnic: Instantiate data structures once Bart Van Assche
2017-10-09 16:51 ` [PATCH 00/47] Address issues detected by static analysis tools Doug Ledford
[not found] ` <1507567892.46071.44.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-11 14:03 ` Dennis Dalessandro
[not found] ` <5d2b3adc-1a19-8acf-9915-d97296be9079-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-11 14:55 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012155404.GR2106@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).