Re: [PATCH] IB/ipoib: Enable pkey and device name decoupling

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]

On Sun, Oct 15, 2017 at 08:47:46AM +0300, Yuval Shaia wrote:
> On Thu, Sep 28, 2017 at 10:53:05AM -0600, Jason Gunthorpe wrote:
> > On Thu, Sep 28, 2017 at 07:47:35PM +0300, Leon Romanovsky wrote:
> > > On Thu, Sep 28, 2017 at 10:34:06AM -0600, Jason Gunthorpe wrote:
> > > > On Wed, Sep 27, 2017 at 12:32:48PM +0300, Yuval Shaia wrote:
> > > > > The sysfs "create_child" interface creates pkey based child interface but
> > > > > derives the name from parent device name and pkey value.
> > > > > This makes administration difficult where pkey values can change but
> > > > > policies encoded with device names do not.
> > > > >
> > > > > We add ability to create a child interface with a user specified name and a
> > > > > specified pkey with a new sysfs "create_named_child" interface (and also
> > > > > add a corresponding "delete_named_child" interface).
> > > > >
> > > > > We also add a new module api interface to query pkey from a netdevice so
> > > > > any kernel users of pkey based child interfaces can query it - since with
> > > > > device name decoupled from pkey, it can no longer be deduced from parsing
> > > > > the device name by other kernel users.
> > > >
> > > > This should all use netlink these days, not more sysfs files.
> > > >
> > > > Leon? What do you think about using rdmatool to provide a command line
> > > > for creating ipoib children?
> > >
> > > As far as I understand ipoib_netlink.c, ipoib_new_child_link() already
> > > implements it and it is supported in "ip".
> >
> > Oh right:
> >
> >   ip link add DEVICE name NAME type ipoib [ pkey PKEY ] [mode MODE ]
>
> So with this interface we can entirely remove the sysfs interface to create
> child, right?

We can't :(, it will break user's scripts.

Thanks

>
> >
> > So what is the point of this series?
> >
> > NAK from me.
> >
> > Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]