Re: [PATCH] rxe_cfg: Fix parsing of ethtool / ifconfig

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2235 bytes --]

Moni ?????

Thanks

On Wed, Oct 11, 2017 at 01:00:24PM -0600, Nathan Hartwell wrote:
> rxe_cfg does not always parse the output of ethtool and ifconfig correctly.
>
> Fix two items:
> 1)  Parsing of ethtool's link speed field to always output a link speed.
> 2)  Parsing of ifconfig's IP address / MTU fields with newer builds of
> ifconfig that have a slightly different output format than in the
> past.
>
> Signed-off-by: Nathan Hartwell <nathan.hartwell-YP+SxaqqoVo2oU8LL9ROB9BPR1lH4CV8@public.gmane.org>
>
> --------------------------------------------------------------------------------
>
> diff --git a/providers/rxe/rxe_cfg.in b/providers/rxe/rxe_cfg.in
> index 0a8583d..8429b28 100755
> --- a/providers/rxe/rxe_cfg.in
> +++ b/providers/rxe/rxe_cfg.in
> @@ -180,9 +180,9 @@ sub get_dev_info {
>                     if ($fields[0] =~ "Link detected") {
>                         $link_state{$eth} = $fields[1];
>                     }
> -           }
> -           elsif ($line =~ "10000baseT") {
> -               $link_speed{$eth} = "10GigE";
> +                   elsif ($fields[0] =~ "Speed") {
> +                       $link_speed{$eth} = $fields[1];
> +                   }
>             }
>         }
>
> @@ -197,6 +197,11 @@ sub get_dev_info {
>                 @fields = split(/\s+/, $line);
>                 $ipv4_addr{$eth} = $fields[0];
>             }
> +           elsif ($line =~ /inet /) {
> +           $line =~ s/^\s+inet //g;
> +               @fields = split(/\s+/, $line);
> +               $ipv4_addr{$eth} = $fields[0];
> +           }
>
>             # get ethernet mtu
>             if ($line =~ /MTU:/) {
> @@ -204,6 +209,11 @@ sub get_dev_info {
>                 @fields = split(/\s+/, $line);
>                 $eth_mtu{$eth} = $fields[0];
>             }
> +           elsif ($line =~ /mtu /) {
> +               $line =~ s/^.*mtu //g;
> +               @fields = split(/\s+/, $line);
> +               $eth_mtu{$eth} = $fields[0];
> +           }
>         }
>      }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]