[PATCH] rds: Fix uninitialized variable

public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] rds: Fix uninitialized variable
@ 2017-10-24 15:02 Håkon Bugge
  2017-10-24 15:46 ` Santosh Shilimkar
  0 siblings, 1 reply; 4+ messages in thread
From: Håkon Bugge @ 2017-10-24 15:02 UTC (permalink / raw)
  To: Santosh Shilimkar, David S . Miller
  Cc: netdev, linux-rdma, rds-devel, linux-kernel

send_flags needs to be initialized before calling
rds_ib_set_wr_signal_state().

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
 net/rds/ib_send.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 6ab39db..8f46755 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
 		send->s_atomic_wr.swap_mask = 0;
 	}
+	send->s_wr.send_flags = 0;
 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
 	send->s_atomic_wr.wr.num_sge = 1;
 	send->s_atomic_wr.wr.next = NULL;
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rds: Fix uninitialized variable
  2017-10-24 15:02 [PATCH] rds: Fix uninitialized variable Håkon Bugge
@ 2017-10-24 15:46 ` Santosh Shilimkar
  0 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2017-10-24 15:46 UTC (permalink / raw)
  To: Håkon Bugge
  Cc: David S . Miller, netdev, linux-rdma, rds-devel, linux-kernel

$subject
s/rds:/rds: ib:

On 10/24/2017 8:02 AM, Håkon Bugge wrote:
> send_flags needs to be initialized before calling
> rds_ib_set_wr_signal_state().
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
Looks fine otherwise. Please re-post with subject fixed.

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] rds: Fix uninitialized variable
@ 2017-10-24 16:07 Håkon Bugge
       [not found] ` <20171024160719.17726-1-Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Håkon Bugge @ 2017-10-24 16:07 UTC (permalink / raw)
  To: Santosh Shilimkar, David S . Miller
  Cc: netdev, linux-rdma, rds-devel, linux-kernel

send_flags needs to be initialized before calling
rds_ib_set_wr_signal_state().

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
 net/rds/ib_send.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 6ab39db..8f46755 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
 		send->s_atomic_wr.swap_mask = 0;
 	}
+	send->s_wr.send_flags = 0;
 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
 	send->s_atomic_wr.wr.num_sge = 1;
 	send->s_atomic_wr.wr.next = NULL;
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

[parent not found: <20171024160719.17726-1-Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH] rds: Fix uninitialized variable
       [not found] ` <20171024160719.17726-1-Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2017-10-24 16:16   ` Håkon Bugge
  0 siblings, 0 replies; 4+ messages in thread
From: Håkon Bugge @ 2017-10-24 16:16 UTC (permalink / raw)
  To: Santosh Shilimkar, David S . Miller
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, OFED mailing list,
	rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Ignore this, sent the old one.

Håkon

> On 24 Oct 2017, at 18:07, Håkon Bugge <Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> 
> send_flags needs to be initialized before calling
> rds_ib_set_wr_signal_state().
> 
> Signed-off-by: Håkon Bugge <haakon.bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> net/rds/ib_send.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
> index 6ab39db..8f46755 100644
> --- a/net/rds/ib_send.c
> +++ b/net/rds/ib_send.c
> @@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
> 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
> 		send->s_atomic_wr.swap_mask = 0;
> 	}
> +	send->s_wr.send_flags = 0;
> 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
> 	send->s_atomic_wr.wr.num_sge = 1;
> 	send->s_atomic_wr.wr.next = NULL;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-24 16:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-24 15:02 [PATCH] rds: Fix uninitialized variable Håkon Bugge
2017-10-24 15:46 ` Santosh Shilimkar
  -- strict thread matches above, loose matches on Subject: below --
2017-10-24 16:07 Håkon Bugge
     [not found] ` <20171024160719.17726-1-Haakon.Bugge-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-24 16:16   ` Håkon Bugge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox