From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH rdma-next 1/2] IB/core: Add scatter end padding flags for WQ and QP Date: Wed, 25 Oct 2017 22:57:07 +0300 Message-ID: <20171025195707.GB16127@mtr-leonro.local> References: <20171017151857.11934-1-leon@kernel.org> <20171017151857.11934-2-leon@kernel.org> <1508954339.3325.45.camel@redhat.com> <20171025190352.GW16127@mtr-leonro.local> <20171025195311.GD998@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hW3Q5Oh0pcvvyJMS" Return-path: Content-Disposition: inline In-Reply-To: <20171025195311.GD998-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Noa Osherovich List-Id: linux-rdma@vger.kernel.org --hW3Q5Oh0pcvvyJMS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 25, 2017 at 01:53:11PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 25, 2017 at 10:03:52PM +0300, Leon Romanovsky wrote: > > On Wed, Oct 25, 2017 at 01:58:59PM -0400, Doug Ledford wrote: > > > On Tue, 2017-10-17 at 18:18 +0300, Leon Romanovsky wrote: > > > > From: Noa Osherovich > > > > > > > > There are root complexes that are able to optimize their > > > > performance when incoming data is multiple full cache lines. > > > > > > > > Scatter end padding is the device's ability to pad the ending of > > > > incoming packets (scatter) > > > > > > I hate this naming. I'm sure people inside of Mellanox have gotten > > > used to it, but this feature really has no bearing on scatter/gather at > > > all. This is merely final write padding. You might have a > > > scatter/gather list, you might have a single buffer. Either way, the > > > PCI root complex couldn't care less about scatter/gather or not, it's > > > all a byte stream to it. I would be much happier with a name that > > > reflected what this really does. > > > > Scatter has more broad meaning than "scatter/gather list". The name > > here came from statistical meaning of "scatter", I'll try to come into > > something more descriptive. > > I don't like it either.. We usually call this 'alignment padding' in CS. We can return to our initial internal name - "RX end padding". I'll consult with architecture tomorrow to hear their suggestion. Thanks > > Jason --hW3Q5Oh0pcvvyJMS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnw7JIACgkQ5GN7iDZy WKf8hBAAurAyDcthsQPmdW2HzmfgN1W8mn9ZZB50IpllPDoAPmXlzUz067tBr7QR YPfxKmRewKK+Vn7fw066KX5uLOm4WFF1LWfzy8TdSVJgTZMG+nC4zfpQvMDsAnKG ebV0KKTCic8xAatTHheJc3klhdxS5BX9RjetRg2uZ4mL8sljL2DxuQK5fq7x9Qhw 4r1aYwtHBJR356JDkro4Zjn+1+tEVUuPhJybRkPUyP5ExTEVJ0vQAa+l6FCiO0Ru mmSa/gEwibsVwyJboRwYzWozzMkwCk+tzzGqaQZYeEpYSnGOtGUvWGZZxiBJq6j6 76eIp4B29jDKNqASZvyfuQmIbttcGkNtq62F6U1KGs85yl+B/93bCyRoPnZHMwsr haK55kuCzy2obynofLQ0HrpEOLQNopjy1SD5UtztDEu29PT/zENmJ2dBj79z9B9A FG61AZJxdbPGXgAmKzVR57bfNMQwZVgKNWPfAsr1qDxrgybpoDQYLv0oCJ1k9oyb FfXK4UzBN52rc/d9IXO9+2x74bL+U1XlJ1BrDqqGBaz1U+ODbM0d4j6Y8Gd9fTBR kxspLFbi0g3dcLyxVjGiOdItjvH72m+NbEFvBEzgwSlJocwfymyMOU1NIZm+OoD7 GWrXwk+13qI/Mz/yEF9B1uEKElyZLZbM0ZlXShi66v0ba41UjOw= =rYHf -----END PGP SIGNATURE----- --hW3Q5Oh0pcvvyJMS-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html