From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Denis Drozdov <denisd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alex Vesker <valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Feras Daoud <ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] IB/ipoib: Block PKEY creation using ip link
Date: Thu, 26 Oct 2017 10:57:39 -0600 [thread overview]
Message-ID: <20171026165739.GB5829@obsidianresearch.com> (raw)
In-Reply-To: <20171026100634.GG16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Thu, Oct 26, 2017 at 01:06:34PM +0300, Leon Romanovsky wrote:
> On Thu, Oct 26, 2017 at 09:47:44AM +0000, Denis Drozdov wrote:
> > Temporary commit that blocks pkey creation using
> > ip link. Example:
> >
> > ip link add link ib2 name ib2.1 type ipoib
> > RTNETLINK answers: Operation not supported
> >
> > Signed-off-by: Feras Daoud <ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Denis Drozdov <denisd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> NAK,
> It is completely wrong and this bug relevant for mlx5 enhanced IPoIB devices,
> but you are disabling all IPoIB capable devices.
+1
If this flow doesn't work with netdev offload, then disable the entire
netdev offload completely until it can be fixed properly.
It is absolutely not OK to selectively break established user APIs like
'ip link' just because a kernel-side optimization is not implemented
correctly, you don't get to do that.
If we knew that the netdev offload patches broke 'ip link' they would
not have been accepted.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-10-26 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 9:47 [PATCH] IB/ipoib: Block PKEY creation using ip link Denis Drozdov
[not found] ` <DB5PR05MB16704ACD20AE16C44B838486B4450-8IvNv+8VlcDlcZmNi56Wl9qRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-10-26 10:06 ` Leon Romanovsky
[not found] ` <20171026100634.GG16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-26 16:57 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026165739.GB5829@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=denisd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox