From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Thomas Bogendoerfer <tbogendoerfer-l3A5Bk7waGM@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailinglist
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed
Date: Sun, 29 Oct 2017 11:00:27 +0200 [thread overview]
Message-ID: <20171029090027.GL16127@mtr-leonro.local> (raw)
In-Reply-To: <CAG9sBKPvK95UpxS_4SO0WxJuCyYrjAhe=Am-Ev2Kp+mQFxyYhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote:
> On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer
> <tbogendoerfer-l3A5Bk7waGM@public.gmane.org> wrote:
> > Following crash happens, if crc algorithm couldn't be allocated:
> >
> > [ 1087.989072] rdma_rxe: loaded
> > [ 1097.855397] PCLMULQDQ-NI instructions are not detected.
> > [ 1097.901220] rdma_rxe: failed to allocate crc algorithmi err:-2
> > [ 1097.901248] BUG: unable to handle kernel
> > [ 1097.901249] NULL pointer dereference
> > [ 1097.901250] at 0000000000000046
> > [...]
> >
> > Reason is that rxe->tfm is assigned the error return, which will then
> > be used for crypto_free_shash() in rxe_cleanup. Fix by using a
> > temporay variable and assigning it rxe->tfm after allocation succeeded.
> >
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer-l3A5Bk7waGM@public.gmane.org>
> Fix looks good only a Fixes line is missing from the commit message. Please add.
temporay -> temporary
Thanks
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-29 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 15:59 [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed Thomas Bogendoerfer
2017-10-29 7:20 ` Moni Shoua
[not found] ` <CAG9sBKPvK95UpxS_4SO0WxJuCyYrjAhe=Am-Ev2Kp+mQFxyYhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-29 9:00 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029090027.GL16127@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=tbogendoerfer-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox