From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter
Date: Sun, 29 Oct 2017 11:52:37 -0600 [thread overview]
Message-ID: <20171029175237.GD4488@ziepe.ca> (raw)
In-Reply-To: <1509295101-14081-3-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Sun, Oct 29, 2017 at 06:38:21PM +0200, idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org wrote:
> +static bool remote_invalidation = true;
> +module_param(remote_invalidation, bool, 0444);
> +MODULE_PARM_DESC(remote_invalidation,
> + "request remote invalidation from subsystem (default: true)");
Please no module options.
If your device has a performance anomaly that makes
SEND_WITH_INVALIDATE slower than local invalidation, then we need to
talk about having a new verbs flag for this situation so all the ULPs
can avoid using SEND_WITH_INVALIDATE..
Sagi, is this really an apples to apples comparison?
When I was talking with Chuck on NFS there were some various issues on
that side that made the local invalidate run faster, but it wasn't
actually working properly.
Does nvme wait for the local invalidate to finish before moving on?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-29 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 16:38 [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs idanb-VPRAkNaXOzVWk0Htik3J/w
[not found] ` <1509295101-14081-1-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 16:38 ` [PATCH 1/2] IB/mlx5: posting klm/mtt list inline in the send queue for reg_wr idanb-VPRAkNaXOzVWk0Htik3J/w
[not found] ` <1509295101-14081-2-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:09 ` Sagi Grimberg
2017-10-29 16:38 ` [PATCH 2/2] nvme-rdma: Add remote_invalidation module parameter idanb-VPRAkNaXOzVWk0Htik3J/w
[not found] ` <1509295101-14081-3-git-send-email-idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:52 ` Jason Gunthorpe [this message]
[not found] ` <20171029175237.GD4488-uk2M96/98Pc@public.gmane.org>
2017-10-30 8:14 ` Sagi Grimberg
[not found] ` <740c93f4-164e-d4e3-97b1-313a0420ae81-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 8:38 ` idanb
[not found] ` <7e038d80-de95-8fb7-e313-825e40c03e88-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-30 9:44 ` Sagi Grimberg
[not found] ` <38523e67-fa00-dd03-5b6f-34cd6f863c8f-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 10:31 ` idanb
[not found] ` <5783e083-93d4-8e72-c380-03fc54a0291b-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-30 10:33 ` Sagi Grimberg
[not found] ` <360f892f-b88d-0947-1590-ab1d64d4da13-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 12:35 ` idanb
2017-10-29 18:24 ` Chuck Lever
[not found] ` <87A0B150-CE67-4C8C-914E-53F66411E1BB-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-30 18:18 ` Chuck Lever
2017-10-30 8:11 ` Sagi Grimberg
[not found] ` <4423f96f-bf42-3603-aa6a-fa259a1d09d1-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-30 8:45 ` idanb
2017-10-29 16:59 ` [PATCH 0/2] Performance Improvents for Secured Mode NVMe over Fabrics and other RDMA ULPs Sagi Grimberg
[not found] ` <e1ba4993-5c77-4754-967c-4da8ec34bf77-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-10-29 17:09 ` Max Gurtovoy
[not found] ` <8cb59a0a-c902-0c0e-27a8-fdf9b98982ac-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-29 17:43 ` Leon Romanovsky
[not found] ` <AM0PR0502MB38906F57CD68C3707F8FE765C5580@AM0PR0502MB3890.eurprd05.prod.outlook.com>
[not found] ` <AM0PR0502MB38906F57CD68C3707F8FE765C5580-EJTefJAZ6OmxAoLrISMGDMDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-10-30 5:21 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029175237.GD4488@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=idanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox