From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: 'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-next] RDMA/cxgb4: Protect from possible dereference
Date: Mon, 30 Oct 2017 07:30:24 +0200 [thread overview]
Message-ID: <20171030053024.GQ16127@mtr-leonro.local> (raw)
In-Reply-To: <001201d350fd$0dd04fa0$2970eee0$@opengridcomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]
On Sun, Oct 29, 2017 at 04:29:50PM -0500, Steve Wise wrote:
> >
> > Smatch tool reports the following error:
> > drivers/infiniband/hw/cxgb4/qp.c:1886
> > c4iw_create_qp() error: we previously assumed 'ucontext'
> > could be null (see line 1804)
> >
> > Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> > drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/hw/cxgb4/qp.c
> > b/drivers/infiniband/hw/cxgb4/qp.c
> > index 57b23e33eb8b..4b3267358dff 100644
> > --- a/drivers/infiniband/hw/cxgb4/qp.c
> > +++ b/drivers/infiniband/hw/cxgb4/qp.c
> > @@ -1843,7 +1843,7 @@ struct ib_qp *c4iw_create_qp(struct ib_pd *pd,
> > struct ib_qp_init_attr *attrs,
> > if (ret)
> > goto err_destroy_qp;
> >
> > - if (udata) {
> > + if (udata && ucontext) {
> > sq_key_mm = kmalloc(sizeof(*sq_key_mm), GFP_KERNEL);
> > if (!sq_key_mm) {
> > ret = -ENOMEM;
>
>
> Hey Leon, doesn't udata imply ucontext? It's not a big deal, though, I
> guess.
Yes, it is, but I don't see any other option to clean RDMA.
➜ linux-rdma git:(rdma-next) x checks
Preparing /tmp/tmp.rkPKPYnNE2 (identifier tmp.rkPKPYnNE2)
Checking out files: 100% (61292/61292), done.
HEAD is now at e183225dff87 RDMA/cxgb4: Protect from possible dereference
Redirecting the output to /tmp/tmp.VZsidBz0jJ
There are 387 errors/warnings
>
> Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>
Thanks
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-30 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 19:34 [PATCH rdma-next] RDMA/cxgb4: Protect from possible dereference Leon Romanovsky
[not found] ` <20171029193435.314-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-29 21:29 ` Steve Wise
2017-10-30 5:30 ` Leon Romanovsky [this message]
2017-11-13 18:53 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030053024.GQ16127@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox