Re: [PATCH rdma-core 1/2] mlx5: Use non-cached mapping when Blueflame is not used

Yishai Hadas
2017-10-29T21:26:04Z

On 10/29/2017 7:33 PM, Jason Gunthorpe wrote:
> On Sun, Oct 29, 2017 at 03:01:09PM +0200, Yishai Hadas wrote:
>
>> diff --git a/providers/mlx5/mlx5dv.h b/providers/mlx5/mlx5dv.h
>> index ffe2c55..9e20a25 100644
>> +++ b/providers/mlx5/mlx5dv.h
>> @@ -632,6 +632,11 @@ enum mlx5dv_set_ctx_attr_type {
>> MLX5DV_CTX_ATTR_BUF_ALLOCATORS = 1,
>> };
>>
>> +enum {
>> + MLX5_MMAP_GET_REGULAR_PAGES_CMD = 0,
>> + MLX5_MMAP_GET_NC_PAGES_CMD = 3,
>> +};
>> +
>
> These are added to a public header, but I couldn't see where they
> would get used by a DV user??

A DV user already had access to the mlx5 mmap command before this series
by using the mlx5dv_get_qp() API:
qp_out->uar_mmap_offset = mqp->bf->uar_mmap_offset;

This offset value was used as part of the mmap() system call and reached
the mlx5 kernel driver, it encoded the required command.

The enum that was added here, just exposed the optional commands which
post this series may be issued including the new
MLX5_MMAP_GET_NC_PAGES_CMD value.