Re: [PATCH rdma-next v1 1/6] IB/uverbs: Allow CQ moderation with modify CQ

Jason Gunthorpe
2017-10-30T14:48:07Z

On Sun, Oct 29, 2017 at 08:28:08PM +0200, Leon Romanovsky wrote:

> > > +int ib_uverbs_ex_modify_cq(struct ib_uverbs_file *file,
> > > + struct ib_device *ib_dev,
> > > + struct ib_udata *ucore,
> > > + struct ib_udata *uhw)
> >
> > Is this really a good idea?
> >
> > Why not ib_uverbs_set_cq_moderation ?
>
> It follows already existed ib_modify_cq(), see commit 2dd571622787
> ("IB/core: Add support for modify CQ")

And that function should have been called set_cq_moderation:

+ * ib_modify_cq - Modifies moderation params of the CQ
+ * @cq: The CQ to modify.
+ * @cq_count: number of CQEs that will trigger an event
+ * @cq_period: max period of time in usec before triggering an event
+ *
+ */
+int ib_modify_cq(struct ib_cq *cq, u16 cq_count, u16 cq_period);

Jason