From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Daniel Jurgens <danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Hal Rosenstock
<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Chris Blake
<chrisrblake93-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: 4.13 ib_mthca NULL pointer dereference with OpenSM
Date: Tue, 31 Oct 2017 09:09:01 -0600 [thread overview]
Message-ID: <20171031150901.GA9852@ziepe.ca> (raw)
In-Reply-To: <60de3bab-f294-dd11-bcae-d179115f7c31-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Tue, Oct 31, 2017 at 10:01:49AM -0500, Daniel Jurgens wrote:
> >> Adding the new return sure makes alot of sense as well..
> >>
> >> Hal, Ira, would you check this routine too? kernel oops's are bad..
> > Patch looks needed for just the point that Parav made above (that if
> > security check fails, then ib_free_recv_mad will cause the
> > mad_recv_wc->rmpp_list to be accessed so it needs to be initialized
> > before security is enforced).
>
> Agree the patch is needed regardless.
Someone please send it..
> > I don't have mthca to try this. Maybe Chris can try this patch (with
> > CONFIG_SECURITY_INFINIBAND=y).
>
> Chris, are you running with SELinux enabled? If this addresses your issue it means permission is denied, so once the crash is resolved additional policy will be required in order for it to work as expected.
If Chris has selinux turned on in his distro would you expect this
test to just fail? Doesn't that mean we have missed installing security labels
for things like opensm?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-31 15:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 17:17 4.13 ib_mthca NULL pointer dereference with OpenSM Chris Blake
[not found] ` <CALpBJjoMLCqzVe5yKp4wCX-X-sH+=zv1QZfMvOWh2Ukh3c2LFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-29 19:11 ` Leon Romanovsky
[not found] ` <20171029191114.GO16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-29 19:35 ` Chris Blake
[not found] ` <CALpBJjoJpgR1QB-gzRJLOjGtjK4T2H4EbG1-R+ndodvznWkgwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-30 7:19 ` Leon Romanovsky
[not found] ` <20171030071956.GU16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-30 18:39 ` Chris Blake
[not found] ` <CALpBJjqWrXu3b12EG2-AWKwKs9v2q5pTf11rXSy04C-5dGta6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-30 19:00 ` Leon Romanovsky
2017-10-30 23:01 ` Jason Gunthorpe
[not found] ` <20171030230156.GA4081-uk2M96/98Pc@public.gmane.org>
2017-10-31 3:16 ` Parav Pandit
[not found] ` <VI1PR0502MB300860F7C004ABFB01079F53D15E0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-10-31 4:24 ` Jason Gunthorpe
[not found] ` <20171031042435.GB7961-uk2M96/98Pc@public.gmane.org>
2017-10-31 5:11 ` Leon Romanovsky
2017-10-31 12:49 ` Hal Rosenstock
[not found] ` <e2a2aa84-71ce-36f0-91af-0854b24d4a6a-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-10-31 15:01 ` Daniel Jurgens
[not found] ` <60de3bab-f294-dd11-bcae-d179115f7c31-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-31 15:09 ` Jason Gunthorpe [this message]
[not found] ` <20171031150901.GA9852-uk2M96/98Pc@public.gmane.org>
2017-10-31 15:12 ` Daniel Jurgens
2017-10-31 15:15 ` Leon Romanovsky
[not found] ` <20171031151521.GK16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-31 15:20 ` Chris Blake
2017-10-31 15:20 ` Daniel Jurgens
[not found] ` <5ab2d58d-8af8-c075-86f0-7010b8316cba-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-31 17:49 ` Chris Blake
[not found] ` <CALpBJjorS-AK3Ua9UuUnWv33rYqBoeAXF9vsFALTff5Qv3hNSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-31 17:58 ` Parav Pandit
2017-10-31 18:22 ` Daniel Jurgens
[not found] ` <fa1abfd0-e9fc-e842-8a21-c214e9dc8e9e-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-31 18:29 ` Chris Blake
[not found] ` <CALpBJjpPzeBMu1QGS8KOmv33A8CTJ2YjFhEhqaPBUpcVy+i3xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-31 18:36 ` Chris Blake
2017-10-31 19:23 ` Jason Gunthorpe
[not found] ` <20171031192340.GA18578-uk2M96/98Pc@public.gmane.org>
2017-10-31 19:44 ` Daniel Jurgens
[not found] ` <799ce928-2e7c-7f60-951a-3a88544b7510-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-11-12 23:38 ` Chris Blake
[not found] ` <CALpBJjogf5ONOmMTr9Z8RQ_78aON=_zSSJ+K-_VQyRRXO6vkAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-13 17:47 ` Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031150901.GA9852@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=chrisrblake93-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox