Re: 4.13 ib_mthca NULL pointer dereference with OpenSM

Jason Gunthorpe
2017-10-31T15:09:01Z

On Tue, Oct 31, 2017 at 10:01:49AM -0500, Daniel Jurgens wrote:

> >> Adding the new return sure makes alot of sense as well..
> >>
> >> Hal, Ira, would you check this routine too? kernel oops's are bad..
> > Patch looks needed for just the point that Parav made above (that if
> > security check fails, then ib_free_recv_mad will cause the
> > mad_recv_wc->rmpp_list to be accessed so it needs to be initialized
> > before security is enforced).
>
> Agree the patch is needed regardless.

Someone please send it..

> > I don't have mthca to try this. Maybe Chris can try this patch (with
> > CONFIG_SECURITY_INFINIBAND=y).
>
> Chris, are you running with SELinux enabled? If this addresses your issue it means permission is denied, so once the crash is resolved additional policy will be required in order for it to work as expected.

If Chris has selinux turned on in his distro would you expect this
test to just fail? Doesn't that mean we have missed installing security labels
for things like opensm?

Jason