From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: "Kalderon,
Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: Zohar Ben Aharon <zoharb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Gil Rockah <gilr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"lunnys-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<lunnys-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"idos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<idos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Elior,
Ariel" <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Amrani,
Ram" <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: Re: Perftest fails when declaring support for MW_TYPE_2A
Date: Wed, 1 Nov 2017 10:45:27 -0600 [thread overview]
Message-ID: <20171101164527.GC1030@ziepe.ca> (raw)
In-Reply-To: <CY1PR0701MB2012478CF41D9E2292887ABC885F0-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
On Wed, Nov 01, 2017 at 03:35:54PM +0000, Kalderon, Michal wrote:
> Hi Mellanox/ Accelio,
>
> There is a very old commit in perftest 96050b8b that assumes bit 23
> in device cap flags means there is driver support for contiguous
> buffer allocation of user data
Wow.
This is
https://github.com/linux-rdma/perftest/blob/master/src/perftest_resources.c#L272
And it is totally unacceptable for upstream'ed open source code to
have crap like this.
Delete it.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-01 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 15:35 Perftest fails when declaring support for MW_TYPE_2A Kalderon, Michal
[not found] ` <CY1PR0701MB2012478CF41D9E2292887ABC885F0-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-11-01 15:46 ` Zohar Ben Aharon
[not found] ` <DB3PR0502MB401294BE74C3F399ABFC9064A95F0-uKIzJYYTohOPJQcb9Mlg0cDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-11-01 15:59 ` Kalderon, Michal
2017-11-01 16:45 ` Jason Gunthorpe [this message]
[not found] ` <20171101164527.GC1030-uk2M96/98Pc@public.gmane.org>
2017-11-06 18:27 ` Kalderon, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101164527.GC1030@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=gilr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=idos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lunnys-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=zoharb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox