From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: Perftest fails when declaring support for MW_TYPE_2A Date: Wed, 1 Nov 2017 10:45:27 -0600 Message-ID: <20171101164527.GC1030@ziepe.ca> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Kalderon, Michal" Cc: Zohar Ben Aharon , Gil Rockah , "lunnys-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "idos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Elior, Ariel" , "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "Amrani, Ram" List-Id: linux-rdma@vger.kernel.org On Wed, Nov 01, 2017 at 03:35:54PM +0000, Kalderon, Michal wrote: > Hi Mellanox/ Accelio, > > There is a very old commit in perftest 96050b8b that assumes bit 23 > in device cap flags means there is driver support for contiguous > buffer allocation of user data Wow. This is https://github.com/linux-rdma/perftest/blob/master/src/perftest_resources.c#L272 And it is totally unacceptable for upstream'ed open source code to have crap like this. Delete it. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html