From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Alex Margolin <alexma-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "'linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC] Registering non-contiguous memory
Date: Wed, 1 Nov 2017 10:56:25 -0600 [thread overview]
Message-ID: <20171101165625.GE1030@ziepe.ca> (raw)
In-Reply-To: <DB5PR05MB1270529922F451A2CACF7AE9B95F0-8IvNv+8VlcCeKfjjHlISstqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Wed, Nov 01, 2017 at 11:11:42AM +0000, Alex Margolin wrote:
> struct verbs_context {
> /* "grows up" - new fields go here */
> + struct ib_mw * (*alloc_mw_ex)(struct ibv_mw_alloc_attr
> *mw_alloc_attr);
This patch is full of weird little mistakes like the above, wouldn't
compile and doesn't really seem capture the proposed API.
We are now asking for complete rdma-core patches before talking about
merging new kernel uapi features. Please retry this RFC with the new
requirement.
This means a patch similar to the above, except functional, and all
the man pages and documentation.
The text in the cover letter should go into either into a man page or
a Documentation/ file.
For very complex uapis like this, an simple example usage is also
going to help.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-01 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 16:46 [RFC] Registering non-contiguous memory Alex Margolin
[not found] ` <VI1PR05MB127817A311C332553E4391AFB9410-79XLn2atqDMOK6E67s+DINqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-02-05 22:44 ` Jason Gunthorpe
[not found] ` <20170205224401.GB26474-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-23 18:21 ` Alex Margolin
[not found] ` <DB5PR05MB12702D1DE9A7E7773FF823ACB93F0-8IvNv+8VlcCeKfjjHlISstqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-03-23 18:40 ` Jason Gunthorpe
2017-02-28 12:31 ` Tom Talpey
[not found] ` <f40f326d-e76b-0471-dc7d-e81b7d07db78-CLs1Zie5N5HQT0dZR+AlfA@public.gmane.org>
2017-03-16 13:32 ` Alex Margolin
2017-11-01 11:11 ` Alex Margolin
[not found] ` <DB5PR05MB1270529922F451A2CACF7AE9B95F0-8IvNv+8VlcCeKfjjHlISstqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-11-01 16:56 ` Jason Gunthorpe [this message]
[not found] ` <20171101165625.GE1030-uk2M96/98Pc@public.gmane.org>
2017-11-02 5:09 ` Leon Romanovsky
[not found] ` <20171102050942.GU16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-02 16:12 ` Jason Gunthorpe
[not found] ` <20171102161222.GH18874-uk2M96/98Pc@public.gmane.org>
2017-11-02 16:31 ` Leon Romanovsky
[not found] ` <20171102163125.GZ16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-02 16:42 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101165625.GE1030@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=alexma-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox