Re: [PATCH rdma-next 00/16] Flow counters support

Jason Gunthorpe
2017-11-02T15:38:48Z

On Thu, Nov 02, 2017 at 08:50:22AM +0200, Alex Rosenbaum wrote:

> by a ibv_modify_qp(qp, {attr{counter}}) or add some 'flush' flag/API,
> or 'more to come' flag until final add_sampling_poing_qp call.

Something along the lines of 'ibv_attach_counters_qp' or 'modify_qp'
(see other comments on overloading modify) is reasonable to me.

So, if every path has a atomic/batch API, do you still want to include
the single counter add capability? It would be fine to me to drop the
object arg, but keep the single counter and differentiated API..

Jason