Re: [PATCH rdma-next 00/16] Flow counters support

Alex Rosenbaum
2017-11-02T16:11:07Z

On Thu, Nov 2, 2017 at 5:38 PM, Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org> wrote:
> On Thu, Nov 02, 2017 at 08:50:22AM +0200, Alex Rosenbaum wrote:
>
> So, if every path has a atomic/batch API, do you still want to include
> the single counter add capability? It would be fine to me to drop the
> object arg, but keep the single counter and differentiated API..

I think single counter add with user space bookkeeping is good and
simple API for applciations.

what do you mean by "differentiated API"?
do you mean keep the ibv_add_xxx_qp() but remove the ibv_qp object
input parameter? same for flow?
if yes, isn't it simpler to do ibv_create_counters_qp() or
ibv_create_counters(QP), and keep a single non differentiated add
sample counter point on a clearly defined ibv_counter