Re: [PATCH rdma-next 00/16] Flow counters support

Jason Gunthorpe
2017-11-01T19:01:19Z

On Wed, Nov 01, 2017 at 08:59:25PM +0200, Alex Rosenbaum wrote:
> On Wed, Nov 1, 2017 at 8:18 PM, Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org> wrote:
> > On Wed, Nov 01, 2017 at 11:32:26AM +0200, Alex Rosenbaum wrote:
> >
> >> > Can mlx do the 'add counter' for any counter??
> >> Not sure I understood your question exactly.
> >
> > I mean, if I have an existing QP, can I start counting packets
> > received?
>
> yes, for QP mlx do support adding/removing the counters on the fly.
> we could do this from ibv_modify_qp() to attach the entire defined
> counter set or for a single counter value from
> ibv_add_sampling_point_qp(counter, idx, qp, [..])

Then I think my proposed API makes the most sense overall since it
captures this use model as well, even if mlx currently does not support
this use model for flow counters.

Jason