Re: [PATCH rdma-next 03/16] IB/core: Introduce counter set describe verb

Christopher Lameter
2017-10-20T10:44:23Z

On Thu, 19 Oct 2017, Yishai Hadas wrote:

> +#define IB_COUNTER_NAME_LEN 64
> +struct ib_counter_set_describe_attr {
> + /* Type that this set refers to, use enum ib_counter_set_type */
> + u8 counted_type;

Gap here of 7 bytes. Maybe move the field to get a more compact
structure?

> + /* Number of instances of this counter-set available in the hardware */
> + u64 num_of_cs;

u16 or u32 should be enough right?

> + /* Attributes of the set, use enum ib_counter_set_attributes */
> + u32 attributes;
> + /* Number of counters in this set */
> + u8 entries_count;

A counter set is limited to 255? Could there be counter sets that have a
thousand or so?