From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 00/16] Flow counters support Date: Wed, 1 Nov 2017 13:01:19 -0600 Message-ID: <20171101190119.GL1030@ziepe.ca> References: <20171023165118.GA18097@obsidianresearch.com> <20171025151734.GA15557@obsidianresearch.com> <20171027155955.GA15922@obsidianresearch.com> <20171029180019.GE4488@ziepe.ca> <20171101181807.GJ1030@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Rosenbaum Cc: Guy Shattah , Yishai Hadas , Yishai Hadas , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Raed Salem , Majd Dibbiny , Alex Rosenbaum , Tzahi Oved List-Id: linux-rdma@vger.kernel.org On Wed, Nov 01, 2017 at 08:59:25PM +0200, Alex Rosenbaum wrote: > On Wed, Nov 1, 2017 at 8:18 PM, Jason Gunthorpe wrote: > > On Wed, Nov 01, 2017 at 11:32:26AM +0200, Alex Rosenbaum wrote: > > > >> > Can mlx do the 'add counter' for any counter?? > >> Not sure I understood your question exactly. > > > > I mean, if I have an existing QP, can I start counting packets > > received? > > yes, for QP mlx do support adding/removing the counters on the fly. > we could do this from ibv_modify_qp() to attach the entire defined > counter set or for a single counter value from > ibv_add_sampling_point_qp(counter, idx, qp, [..]) Then I think my proposed API makes the most sense overall since it captures this use model as well, even if mlx currently does not support this use model for flow counters. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html