From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 00/16] Flow counters support Date: Wed, 1 Nov 2017 15:16:29 -0600 Message-ID: <20171101211629.GA18874@ziepe.ca> References: <20171025151734.GA15557@obsidianresearch.com> <20171027155955.GA15922@obsidianresearch.com> <20171029180019.GE4488@ziepe.ca> <20171101181807.GJ1030@ziepe.ca> <20171101190119.GL1030@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Rosenbaum Cc: Guy Shattah , Yishai Hadas , Yishai Hadas , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Raed Salem , Majd Dibbiny , Alex Rosenbaum , Tzahi Oved List-Id: linux-rdma@vger.kernel.org On Wed, Nov 1, 2017 at 1:46 PM, Alex Rosenbaum wrote: >> Then I think my proposed API makes the most sense overall since it >> captures this use model as well, even if mlx currently does not support >> this use model for flow counters. > it will force the kernel syscall on each modify, which is something > that will limit the usage at scale. No, it doesn't force that. As we've talked about the driver should book-keep in user space as required. > doing the bookkeeping in user space will require a trigger to commit > this to kernel/HW, which can be the modify() or an additional API. The trigger to push things to the kernel is something like creating a flow steering object. The driver can bundle the create of the counter object, and the send of the counters to add, in with the syscall for creating the flow steering object. Same argument for QP, similar argument for attaching to an existing QP. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html