public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
Cc: "rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org"
	<rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
	"chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
	<chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"corbet-T1hC0tSOHrs@public.gmane.org"
	<corbet-T1hC0tSOHrs@public.gmane.org>
Subject: Re: [PATCH RFC] rdma/ib: Add trace point macros to display human-readable values
Date: Thu, 2 Nov 2017 08:19:34 +0200	[thread overview]
Message-ID: <20171102061934.GX16127@mtr-leonro.local> (raw)
In-Reply-To: <1509551986.2530.20.camel-Sjgp3cTcYWE@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

On Wed, Nov 01, 2017 at 03:59:47PM +0000, Bart Van Assche wrote:
> On Wed, 2017-11-01 at 08:27 +0200, Leon Romanovsky wrote:
> > Bart, Steve
> >
> > You attended the MS track, and for the rest of us, the quote below
> > sounds a little bit cryptic. Does the quote below mean that Chuck's
> > proposal is no-go?
> >
> > From LWN.net "Another attempt to address the tracepoint ABI problem" [1]
> >
> > "The solution that was arrived at for now, as related by Torvalds,
> >  is to hold off on adding explicit tracepoints to the kernel. Instead,
> >  support will be added to make it easy for an application to attach a
> >  BPF script to any function in the kernel, with access to that function's
> >  arguments."
> >
> > [1] https://lwn.net/Articles/737530/
>
> What I remember is that Linus does not require us to avoid breaking user
> space applications that use tracepoints. Powertop however is an exception
> to this rule. Although it uses tracepoints, we must not break it. I also
> remember that Linus noticed that the purpose of many tracepoints is to
> allow users to trace a function and its arguments. Linus wants a better
> approach for tracing kernel functions than adding an explicit tracepoint
> to each kernel function. Maybe I wasn't listening carefully enough but I
> haven't heard Linus saying that we would not be allowed to add new
> tracepoints.

Like Steven, I wasn't in MS either and the sentence "is to hold off on adding explicit
tracepoints to the kernel" made me worry.

Thanks.

>
> Bart.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-11-02  6:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 22:01 [PATCH RFC] rdma/ib: Add trace point macros to display human-readable values Chuck Lever
     [not found] ` <20171030215809.31286.46685.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-11-01  6:27   ` Leon Romanovsky
     [not found]     ` <20171101062743.GO16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-01 15:29       ` Steven Rostedt
     [not found]         ` <20171101112932.4485ba6a-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2017-11-02  6:06           ` Leon Romanovsky
2017-11-01 15:59       ` Bart Van Assche
     [not found]         ` <1509551986.2530.20.camel-Sjgp3cTcYWE@public.gmane.org>
2017-11-02  6:19           ` Leon Romanovsky [this message]
2017-11-02 16:18   ` Chuck Lever
     [not found]     ` <0370B773-BB98-49BD-9C9D-DFD3220CCC20-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-11-02 16:34       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102061934.GX16127@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=corbet-T1hC0tSOHrs@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox