From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core] librdmacm: Remove unneeded condition Date: Thu, 2 Nov 2017 10:45:28 -0600 Message-ID: <20171102164528.GM18874@ziepe.ca> References: <20171102135134.5728-1-yuval.shaia@oracle.com> <1509635426.2484.9.camel@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1509635426.2484.9.camel-Sjgp3cTcYWE@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: "yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org" , "sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, Nov 02, 2017 at 03:10:27PM +0000, Bart Van Assche wrote: > On Thu, 2017-11-02 at 15:51 +0200, Yuval Shaia wrote: > > The check makes no difference - remove it. > > Shouldn't the description have been "Passing zero as third argument to > memcpy() is allowed so the if-test is not necessary. Hence leave it out"? +1 Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html