From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>,
Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org"
<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH rdma-core] librdmacm: Remove unneeded condition
Date: Sun, 5 Nov 2017 11:30:15 +0200 [thread overview]
Message-ID: <20171105093014.GA3948@yuvallap> (raw)
In-Reply-To: <20171105072657.GF31774-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Sun, Nov 05, 2017 at 09:26:58AM +0200, Leon Romanovsky wrote:
> On Thu, Nov 02, 2017 at 10:45:28AM -0600, Jason Gunthorpe wrote:
> > On Thu, Nov 02, 2017 at 03:10:27PM +0000, Bart Van Assche wrote:
> > > On Thu, 2017-11-02 at 15:51 +0200, Yuval Shaia wrote:
> > > > The check makes no difference - remove it.
> > >
> > > Shouldn't the description have been "Passing zero as third argument to
> > > memcpy() is allowed so the if-test is not necessary. Hence leave it out"?
> >
> > +1
>
> Yuval ?
Thanks Leon,
Just post new pull request with the revised commit message.
If still v1 is needed here for review then i'll post it.
>
> Thanks
>
> >
> > Jason
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-05 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 13:51 [PATCH rdma-core] librdmacm: Remove unneeded condition Yuval Shaia
[not found] ` <20171102135134.5728-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-11-02 15:10 ` Bart Van Assche
[not found] ` <1509635426.2484.9.camel-Sjgp3cTcYWE@public.gmane.org>
2017-11-02 16:45 ` Jason Gunthorpe
[not found] ` <20171102164528.GM18874-uk2M96/98Pc@public.gmane.org>
2017-11-05 7:26 ` Leon Romanovsky
[not found] ` <20171105072657.GF31774-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-05 9:30 ` Yuval Shaia [this message]
2017-11-05 13:27 ` Leon Romanovsky
2017-11-02 15:12 ` Leon Romanovsky
[not found] ` <20171102151252.GY16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-02 18:03 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105093014.GA3948@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox