Re: [PATCH rdma-core] librdmacm: Remove unneeded condition

Leon Romanovsky
2017-11-02T15:12:52Z

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On Thu, Nov 02, 2017 at 03:51:34PM +0200, Yuval Shaia wrote:
> The check makes no difference - remove it.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> librdmacm/cma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/librdmacm/cma.c b/librdmacm/cma.c
> index 7aaf45f2..6eebe71b 100644
> --- a/librdmacm/cma.c
> +++ b/librdmacm/cma.c
> @@ -880,8 +880,8 @@ static int rdma_resolve_addr2(struct rdma_cm_id *id, struct sockaddr *src_addr,
> CMA_INIT_CMD(&cmd, sizeof cmd, RESOLVE_ADDR);
> id_priv = container_of(id, struct cma_id_private, id);
> cmd.id = id_priv->handle;
> - if ((cmd.src_size = src_len))

Isn't this "=" should be "=="?

> - memcpy(&cmd.src_addr, src_addr, src_len);
> + cmd.src_size = src_len;
> + memcpy(&cmd.src_addr, src_addr, src_len);
> memcpy(&cmd.dst_addr, dst_addr, dst_len);
> cmd.dst_size = dst_len;
> cmd.timeout_ms = timeout_ms;
> --
> 2.13.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]