[PATCH rdma-core 0/5] Perform package tests in Travis CI

[PATCH rdma-core 0/5] Perform package tests in Travis CI

[Leon Romanovsky]

This patchset comes from Alaa and he adds to Travis CI ability
to reuse our cbuild script to build various packages.

The PR is https://github.com/linux-rdma/rdma-core/pull/241

Thanks

Cc: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Cc: Nicolas Morey-Chaisemartin <nmoreychaisemartin-l3A5Bk7waGM@public.gmane.org>

Alaa Hleihel (5):
  cbuild: Add udev dependency to package list of SuSE Leap
  cbuild: Properly create tarball for SuSE
  travis: Add RedHat and SuSE rpmbuild support
  buildlib/cbuild: Add Ubuntu artful
  travis: Test Debian packaging under Artful container

 .travis.yml                 |  4 ++++
 buildlib/cbuild             | 27 ++++++++++++++++++++-------
 buildlib/package-build-test | 15 +++++++++++++++
 buildlib/travis-build       | 14 --------------
 4 files changed, 39 insertions(+), 21 deletions(-)
 create mode 100755 buildlib/package-build-test

--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Leon Romanovsky]

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

rpmbuild under SUSE requires udev and produces the following errors:

error: Failed build dependencies:
        pkgconfig(udev) is needed by rdma-core-16-0.x86_64

Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 buildlib/cbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/buildlib/cbuild b/buildlib/cbuild
index 918bf233..d1455b6f 100755
--- a/buildlib/cbuild
+++ b/buildlib/cbuild
@@ -298,6 +298,7 @@ class leap(ZypperEnvironment):
         'cmake',
         'gcc',
         'libnl3-devel',
+        'udev',
         'libudev-devel',
         'make',
         'ninja',
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Nicolas Morey-Chaisemartin]

Good catch !
Thanks

Le 02/11/2017 à 17:55, Leon Romanovsky a écrit :
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> rpmbuild under SUSE requires udev and produces the following errors:
>
> error: Failed build dependencies:
>         pkgconfig(udev) is needed by rdma-core-16-0.x86_64
>
> Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Reviewed-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin-l3A5Bk7waGM@public.gmane.org>
> ---
>  buildlib/cbuild | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/buildlib/cbuild b/buildlib/cbuild
> index 918bf233..d1455b6f 100755
> --- a/buildlib/cbuild
> +++ b/buildlib/cbuild
> @@ -298,6 +298,7 @@ class leap(ZypperEnvironment):
>          'cmake',
>          'gcc',
>          'libnl3-devel',
> +        'udev',
>          'libudev-devel',
>          'make',
>          'ninja',
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Nicolas Morey-Chaisemartin]

Leon, Jason, is there any news on switching the upstream validation to build/validate for all distrib instead of just the "travis" one ?

Nicolas

Le 02/11/2017 à 17:55, Leon Romanovsky a écrit :
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> rpmbuild under SUSE requires udev and produces the following errors:
>
> error: Failed build dependencies:
>         pkgconfig(udev) is needed by rdma-core-16-0.x86_64
>
> Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
>  buildlib/cbuild | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/buildlib/cbuild b/buildlib/cbuild
> index 918bf233..d1455b6f 100755
> --- a/buildlib/cbuild
> +++ b/buildlib/cbuild
> @@ -298,6 +298,7 @@ class leap(ZypperEnvironment):
>          'cmake',
>          'gcc',
>          'libnl3-devel',
> +        'udev',
>          'libudev-devel',
>          'make',
>          'ninja',
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]

On Thu, Nov 02, 2017 at 06:32:09PM +0100, Nicolas Morey-Chaisemartin wrote:
> Leon, Jason, is there any news on switching the upstream validation to build/validate for all distrib instead of just the "travis" one ?

This is the ultimate goal of this series.

After this series will be fixed and merged, we will have containerized SuSE/CentOS/Debian builds in travis,
and next step will be upload those artifacts to https://packagecloud.io/, so people won't need to create
distro packages for master branch. It will be there for them.

In regards of schedule, there is already weekend in IL and Alaa will continue
to work on this series next week. After that, I'll setup and connect packagecloud
to our account.

Actual validation on real HW is performed by vendors internally.

Thanks

>
> Nicolas
>
> Le 02/11/2017 à 17:55, Leon Romanovsky a écrit :
> > From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > rpmbuild under SUSE requires udev and produces the following errors:
> >
> > error: Failed build dependencies:
> >         pkgconfig(udev) is needed by rdma-core-16-0.x86_64
> >
> > Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> >  buildlib/cbuild | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/buildlib/cbuild b/buildlib/cbuild
> > index 918bf233..d1455b6f 100755
> > --- a/buildlib/cbuild
> > +++ b/buildlib/cbuild
> > @@ -298,6 +298,7 @@ class leap(ZypperEnvironment):
> >          'cmake',
> >          'gcc',
> >          'libnl3-devel',
> > +        'udev',
> >          'libudev-devel',
> >          'make',
> >          'ninja',
> > --
> > 2.14.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Nicolas Morey-Chaisemartin]

Le 02/11/2017 à 18:42, Leon Romanovsky a écrit :
> On Thu, Nov 02, 2017 at 06:32:09PM +0100, Nicolas Morey-Chaisemartin wrote: >> Leon, Jason, is there any news on switching the upstream validation to build/validate for all distrib instead of just the "travis" one ? > > This is the ultimate goal of this series.
Sounds good. In that case, it might be worth adding tumbleweed to the distrib beeing built.
Most of the SUSE bleeding-edge user are using TW as it provides the latest kernel/packages.

> > > After this series will be fixed and merged, we will have containerized SuSE/CentOS/Debian builds in travis, > and next step will be upload those artifacts to https://packagecloud.io/, so people won't need to create > distro packages for master branch. It will be there for them.
FYI, I've already setup something in OBS that does it for the SUSE packages:
https://build.opensuse.org/package/show/science:HPC:Head/rdma-core

I've a Jenkins job that pulls github and automatically update this OBS repository.
They definitly should *NOT* be used for anything but testing.

> > > In regards of schedule, there is already weekend in IL and Alaa will continue > to work on this series next week. After that, I'll setup and connect packagecloud > to our account.
Great !

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Thu, Nov 02, 2017 at 07:04:36PM +0100, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 02/11/2017 à 18:42, Leon Romanovsky a écrit :
> > On Thu, Nov 02, 2017 at 06:32:09PM +0100, Nicolas Morey-Chaisemartin wrote: >> Leon, Jason, is there any news on switching the upstream validation to build/validate for all distrib instead of just the "travis" one ? > > This is the ultimate goal of this series.
> Sounds good. In that case, it might be worth adding tumbleweed to the distrib beeing built.
> Most of the SUSE bleeding-edge user are using TW as it provides the latest kernel/packages.

The preference is to have one latest distribution per distro, otherwise
the CI will take a lot of time to complete. It makes sense to replace
leap with tumblweed.

>
> > > > After this series will be fixed and merged, we will have containerized SuSE/CentOS/Debian builds in travis, > and next step will be upload those artifacts to https://packagecloud.io/, so people won't need to create > distro packages for master branch. It will be there for them.
> FYI, I've already setup something in OBS that does it for the SUSE packages:
> https://build.opensuse.org/package/show/science:HPC:Head/rdma-core
>
> I've a Jenkins job that pulls github and automatically update this OBS repository.
> They definitly should *NOT* be used for anything but testing.
>
> > > > In regards of schedule, there is already weekend in IL and Alaa will continue > to work on this series next week. After that, I'll setup and connect packagecloud > to our account.
> Great !
>
> Nicolas
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Alaa Hleihel]

On 02/11/2017 20:32, Leon Romanovsky wrote:
> On Thu, Nov 02, 2017 at 07:04:36PM +0100, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 02/11/2017 à 18:42, Leon Romanovsky a écrit :
>>> On Thu, Nov 02, 2017 at 06:32:09PM +0100, Nicolas Morey-Chaisemartin wrote: >> Leon, Jason, is there any news on switching the upstream validation to build/validate for all distrib instead of just the "travis" one ? > > This is the ultimate goal of this series.
>> Sounds good. In that case, it might be worth adding tumbleweed to the distrib beeing built.
>> Most of the SUSE bleeding-edge user are using TW as it provides the latest kernel/packages.
> The preference is to have one latest distribution per distro, otherwise
> the CI will take a lot of time to complete. It makes sense to replace
> leap with tumblweed.

Hi Nicolas,

I've tried to build RPMs for tumbleweed, but it fails with the following error:
$ buildlib/cbuild pkg tumbleweed
error: Failed build dependencies:
        curl-mini is needed by rdma-core-16-0.x86_64

Seems like there is no such package available for Tumbleweed ..

########################################################################
$ buildlib/cbuild pkg tumbleweed --run-shell
builder-24bcec44f958:~/rpmbuild # cat /etc/issue
Welcome to openSUSE Tumbleweed 20171102 - Kernel \r (\l).

builder-24bcec44f958:~/rpmbuild # zypper search curl-mini
Loading repository data...
Reading installed packages...
No matching items found.

builder-24bcec44f958:~/rpmbuild # zypper search curl
Loading repository data...
Reading installed packages...

S | Name                | Summary                                                      | Type
--+---------------------+--------------------------------------------------------------+--------
  | curl                | A Tool for Transferring Data from URLs                       | package
  | curlftpfs           | Filesystem for mounting FTP hosts using FUSE and libcurl     | package
  | flickcurl           | Command-Line Tools for the Flickr Web Service                | package
  | flickcurl-doc       | Documentation for flickcurl, a Flickr Web Service C library  | package
  | gambas3-gb-net-curl | The advanced networking component for Gambas                 | package
  | ghc-curl            | Haskell binding to libcurl                                   | package
  | ghc-curl-devel      | Haskell curl library development files                       | package
  | libcurl-devel       | A Tool for Transferring Data from URLs                       | package
  | libcurl-devel-32bit | A Tool for Transferring Data from URLs                       | package
i | libcurl4            | Version 4 of cURL shared library                             | package
  | libcurl4-32bit      | Version 4 of cURL shared library                             | package
  | libflickcurl-devel  | Development files for flickurl, a Flickr Web Service library | package
  | libflickcurl0       | C Library API to the Flickr Web Service                      | package
  | libflickcurl0-32bit | C Library API to the Flickr Web Service                      | package
  | php7-curl           | libcurl integration for PHP                                  | package
  | python-pycurl-doc   | Documentation for python-curl                                | package
  | python2-pycurl      | PycURL -- cURL library module                                | package
  | python3-pycurl      | PycURL -- cURL library module                                | package
  | qemu-block-curl     | Universal CPU emulator -- cURL block support                 | package
  | syslog-ng-curl      | Curl (HTTP) destination support for syslog-ng                | package
  | tclcurl             | Tcl Binding to libcurl                                       | package
  | xmms2-plugin-curl   | Curl support for xmms2                                       | package
########################################################################


However, after removing the requirement for curl-mini, I was able to build RPMs successfully under Tumbleweed.
Can I submit a patch for removing these lines ?

--- a/suse/rdma-core.spec
+++ b/suse/rdma-core.spec

-%if 0%{?suse_version} >= 1330
-BuildRequires:  curl-mini
-%endif
-


Regards,
Alaa


>>>>> After this series will be fixed and merged, we will have containerized SuSE/CentOS/Debian builds in travis, > and next step will be upload those artifacts to https://packagecloud.io/, so people won't need to create > distro packages for master branch. It will be there for them.
>> FYI, I've already setup something in OBS that does it for the SUSE packages:
>> https://build.opensuse.org/package/show/science:HPC:Head/rdma-core
>>
>> I've a Jenkins job that pulls github and automatically update this OBS repository.
>> They definitly should *NOT* be used for anything but testing.
>>
>>>>> In regards of schedule, there is already weekend in IL and Alaa will continue > to work on this series next week. After that, I'll setup and connect packagecloud > to our account.
>> Great !
>>
>> Nicolas
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Jason Gunthorpe]

On Sun, Nov 05, 2017 at 10:13:57AM +0200, Alaa Hleihel wrote:
 
> -%if 0%{?suse_version} >= 1330
> -BuildRequires:? curl-mini
> -%endif

No idea what it would need curl to build, so the above seems right to me?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Alaa Hleihel]

On 06/11/2017 4:05, Jason Gunthorpe wrote:
> On Sun, Nov 05, 2017 at 10:13:57AM +0200, Alaa Hleihel wrote:
>  
>> -%if 0%{?suse_version} >= 1330
>> -BuildRequires:? curl-mini
>> -%endif
> No idea what it would need curl to build, so the above seems right to me?
>
> Jason

I also don't believe that curl is required for build. But, I think we should wait for Nicolas to comment before removing these lines.

Regards,
Alaa
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Nicolas Morey-Chaisemartin]

Le 06/11/2017 à 08:58, Alaa Hleihel a écrit :
>
> On 06/11/2017 4:05, Jason Gunthorpe wrote:
>> On Sun, Nov 05, 2017 at 10:13:57AM +0200, Alaa Hleihel wrote:
>>  
>>> -%if 0%{?suse_version} >= 1330
>>> -BuildRequires:? curl-mini
>>> -%endif
>> No idea what it would need curl to build, so the above seems right to me?
>>
>> Jason
> I also don't believe that curl is required for build. But, I think we should wait for Nicolas to comment before removing these lines.
>
> Regards,
> Alaa
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

There is no direct dependency to curl but an indirect one that I don't remember.
This is required to avoid cyclic build dependency in our build system. (something like curl requires boost which requires rdma-core which requires curl through some dependencies)

I don't know why it's not available on download.opensuse.org... I'll check with the guy in charge and submit a patch if needed

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 1/5] cbuild: Add udev dependency to package list of SuSE Leap

[Jason Gunthorpe]

On Mon, Nov 06, 2017 at 10:15:34AM +0100, Nicolas Morey-Chaisemartin wrote:

> There is no direct dependency to curl but an indirect one that I
> don't remember.

This is still current for rdma-core?

> This is required to avoid cyclic build dependency in our build
> system. (something like curl requires boost which requires rdma-core
> which requires curl through some dependencies)

A comment would help :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Leon Romanovsky]

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

The tarball was not created at the expected path by SUSE scripts,
causing rpmbuild to fail with the following error:
error: File /usr/src/packages/SOURCES/rdma-core-16.tar.gz: No such file or directory

This patch fixes the issue by adding ".rpmmacros" file to root's home
folder and sets "%_topdir" to the path where we place the source tarball.

Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 buildlib/cbuild | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/buildlib/cbuild b/buildlib/cbuild
index d1455b6f..098bec9a 100755
--- a/buildlib/cbuild
+++ b/buildlib/cbuild
@@ -415,13 +415,15 @@ def run_rpm_build(args,spec_file,env):

     image_id = get_image_id(args,env.image_name());
     with private_tmp(args) as tmpdir:
-        os.mkdir(os.path.join(tmpdir,"SOURCES"));
+        builddir = os.path.join(tmpdir,"builddir")
+        os.mkdir(builddir);
+        os.mkdir(os.path.join(builddir,"SOURCES"));
         os.mkdir(os.path.join(tmpdir,"tmp"));

         subprocess.check_call(["git","archive",
                                # This must match the prefix generated buildlib/github-release
                                "--prefix","%s-%s/"%(project,get_version()),
-                               "--output",os.path.join(tmpdir,"SOURCES",tarfn),
+                               "--output",os.path.join(builddir,"SOURCES",tarfn),
                                "HEAD"]);

         with open(spec_file,"r") as inF:
@@ -431,18 +433,21 @@ def run_rpm_build(args,spec_file,env):
             outF.write("".join(spec));

         home = os.path.join(os.path.sep,"home",os.getenv("LOGNAME"));
-        vdir = os.path.join(home,"rpmbuild");

         opts = [
             "run",
             "--rm=true",
-            "-v","%s:%s"%(tmpdir,vdir),
-            "-w",vdir,
+            "-v","%s:%s"%(tmpdir,home),
+            "-w",home,
             "-h","builder-%s"%(image_id[:12]),
             "-e","HOME=%s"%(home),
-            "-e","TMPDIR=%s"%(os.path.join(vdir,"tmp")),
+            "-e","TMPDIR=%s"%(os.path.join(home,"tmp")),
         ];

+        # set _topdir for rpmbuild under SUSE since it's different than RedHat
+        with open(os.path.join(tmpdir,".rpmmacros"),"w") as F:
+            print >> F,"%%_topdir %s"%os.path.join(home,"builddir")
+
         # rpmbuild complains if we do not have an entry in passwd and group
         # for the user we are going to use to do the build.
         with open(os.path.join(tmpdir,"go.py"),"w") as F:
@@ -459,7 +464,7 @@ os.setuid({uid:d});
 for ln in subprocess.check_output(["rpmspec","-P",{tspec_file!r}]).splitlines():
    if ln.startswith("Source:"):
       tarfn = ln.strip().partition(' ')[2].strip();
-os.symlink({tarfn!r},os.path.join("SOURCES",tarfn));
+os.symlink({tarfn!r},os.path.join("builddir","SOURCES",tarfn));
 """.format(passwd=":".join(str(I) for I in pwd.getpwuid(os.getuid())),
            group=":".join(str(I) for I in grp.getgrgid(os.getgid())),
            uid=os.getuid(),
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 06:55:53PM +0200, Leon Romanovsky wrote:
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> The tarball was not created at the expected path by SUSE scripts,
> causing rpmbuild to fail with the following error:
> error: File /usr/src/packages/SOURCES/rdma-core-16.tar.gz: No such file or directory
> 
> This patch fixes the issue by adding ".rpmmacros" file to root's home
> folder and sets "%_topdir" to the path where we place the source tarball.

Alaa,

I'm not certain what this patch is about, I don't see these errors
here:

$ buildlib/cbuild pkg opensuse-42.2 
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.JSkP2f
+ umask 022
+ cd /home/jgg/rpmbuild/BUILD
+ cd /home/jgg/rpmbuild/BUILD
+ rm -rf rdma-core-16
+ /usr/bin/gzip -dc /home/jgg/rpmbuild/SOURCES/rdma-core-16.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd rdma-core-16
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.rzpkKs
+ umask 022
+ cd /home/jgg/rpmbuild/BUILD
+ /usr/bin/rm -rf /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
++ dirname /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
+ /usr/bin/mkdir -p /home/jgg/rpmbuild/BUILDROOT
+ /usr/bin/mkdir /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
+ cd rdma-core-16

How can you be getting such a significantly different result?

Are you running cbuild as root or something? What is the docker
command the script uses?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Nicolas Morey-Chaisemartin]

Same here. Cannot reproduce the original issue...

Le 02/11/2017 à 18:17, Jason Gunthorpe a écrit :
> On Thu, Nov 02, 2017 at 06:55:53PM +0200, Leon Romanovsky wrote:
>> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> The tarball was not created at the expected path by SUSE scripts,
>> causing rpmbuild to fail with the following error:
>> error: File /usr/src/packages/SOURCES/rdma-core-16.tar.gz: No such file or directory
>>
>> This patch fixes the issue by adding ".rpmmacros" file to root's home
>> folder and sets "%_topdir" to the path where we place the source tarball.
> Alaa,
>
> I'm not certain what this patch is about, I don't see these errors
> here:
>
> $ buildlib/cbuild pkg opensuse-42.2 
> Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.JSkP2f
> + umask 022
> + cd /home/jgg/rpmbuild/BUILD
> + cd /home/jgg/rpmbuild/BUILD
> + rm -rf rdma-core-16
> + /usr/bin/gzip -dc /home/jgg/rpmbuild/SOURCES/rdma-core-16.tar.gz
> + /bin/tar -xf -
> + STATUS=0
> + '[' 0 -ne 0 ']'
> + cd rdma-core-16
> + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> + exit 0
> Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.rzpkKs
> + umask 022
> + cd /home/jgg/rpmbuild/BUILD
> + /usr/bin/rm -rf /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> ++ dirname /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> + /usr/bin/mkdir -p /home/jgg/rpmbuild/BUILDROOT
> + /usr/bin/mkdir /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> + cd rdma-core-16
>
> How can you be getting such a significantly different result?
>
> Are you running cbuild as root or something? What is the docker
> command the script uses?
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

On Thu, Nov 02, 2017 at 11:17:38AM -0600, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 06:55:53PM +0200, Leon Romanovsky wrote:
> > From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > The tarball was not created at the expected path by SUSE scripts,
> > causing rpmbuild to fail with the following error:
> > error: File /usr/src/packages/SOURCES/rdma-core-16.tar.gz: No such file or directory
> >
> > This patch fixes the issue by adding ".rpmmacros" file to root's home
> > folder and sets "%_topdir" to the path where we place the source tarball.
>
> Alaa,
>
> I'm not certain what this patch is about, I don't see these errors
> here:
>
> $ buildlib/cbuild pkg opensuse-42.2
> Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.JSkP2f
> + umask 022
> + cd /home/jgg/rpmbuild/BUILD
> + cd /home/jgg/rpmbuild/BUILD
> + rm -rf rdma-core-16
> + /usr/bin/gzip -dc /home/jgg/rpmbuild/SOURCES/rdma-core-16.tar.gz
> + /bin/tar -xf -
> + STATUS=0
> + '[' 0 -ne 0 ']'
> + cd rdma-core-16
> + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> + exit 0
> Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.rzpkKs
> + umask 022
> + cd /home/jgg/rpmbuild/BUILD
> + /usr/bin/rm -rf /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> ++ dirname /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> + /usr/bin/mkdir -p /home/jgg/rpmbuild/BUILDROOT
> + /usr/bin/mkdir /home/jgg/rpmbuild/BUILDROOT/rdma-core-16-0.x86_64
> + cd rdma-core-16
>
> How can you be getting such a significantly different result?
>
> Are you running cbuild as root or something? What is the docker
> command the script uses?

For me too, it doesn't reproduce, most probably Alaa run it as a root.

Thanks

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 07:57:35PM +0200, Leon Romanovsky wrote:

> > Are you running cbuild as root or something? What is the docker
> > command the script uses?
> 
> For me too, it doesn't reproduce, most probably Alaa run it as a root.

Okay lets instead ban running cbuild as root?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On Thu, Nov 02, 2017 at 12:12:17PM -0600, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 07:57:35PM +0200, Leon Romanovsky wrote:
>
> > > Are you running cbuild as root or something? What is the docker
> > > command the script uses?
> >
> > For me too, it doesn't reproduce, most probably Alaa run it as a root.
>
> Okay lets instead ban running cbuild as root?

I'm fine with that, but lets wait till Sunday before dropping this patch,
so Alaa will have chance to respond.

Thanks

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 2/5] cbuild: Properly create tarball for SuSE

[Alaa Hleihel]

On 02/11/2017 20:25, Leon Romanovsky wrote:
> On Thu, Nov 02, 2017 at 12:12:17PM -0600, Jason Gunthorpe wrote:
>> On Thu, Nov 02, 2017 at 07:57:35PM +0200, Leon Romanovsky wrote:
>>
>>>> Are you running cbuild as root or something? What is the docker
>>>> command the script uses?
>>> For me too, it doesn't reproduce, most probably Alaa run it as a root.
>> Okay lets instead ban running cbuild as root?
> I'm fine with that, but lets wait till Sunday before dropping this patch,
> so Alaa will have chance to respond.
>
> Thanks

Hi,

Correct, I saw this issue when I tested the build using 'root' user.
I'll drop this patch.

Regards,
Alaa


>> Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 3/5] travis: Add RedHat and SuSE rpmbuild support

[Leon Romanovsky]

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Provide a new script for testing rpmbuild under RedHat and SuSE
environments which validates both of the suse/rdma-core.spec and
redhat/rdma-core.spec specfiles.

The script performs the RPM package build test by utilizing the existing
cbuild tool.

Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 .travis.yml                 |  4 ++++
 buildlib/package-build-test | 15 +++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100755 buildlib/package-build-test

diff --git a/.travis.yml b/.travis.yml
index c190a241..4d7b0cc0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -42,6 +42,9 @@ addons:
       - gcc-multilib
       - lib32gcc-7-dev

+service:
+    - docker
+
 before_script:
   - export LATEST_GCC_LINARO_URL=`wget -qO - https://releases.linaro.org/components/toolchain/binaries/latest/aarch64-linux-gnu/ | grep -o '<a href=['"'"'"].*gcc-linaro-.*x86_64_aarch64-linux-gnu.tar.xz['"'"'"]'  |  sed -e 's/^<a href=["'"'"']//' -e 's/["'"'"']$//'`
   - export LATEST_GCC_LINARO_TAR=`basename $LATEST_GCC_LINARO_URL`
@@ -51,6 +54,7 @@ before_script:
 script:
   - buildlib/travis-build
   - buildlib/travis-checkpatch
+  - buildlib/package-build-test
   - buildlib/github-release
 deploy:
   # Deploy assets to Github releases
diff --git a/buildlib/package-build-test b/buildlib/package-build-test
new file mode 100755
index 00000000..d767f61f
--- /dev/null
+++ b/buildlib/package-build-test
@@ -0,0 +1,15 @@
+#!/bin/bash
+
+# fail on errors
+set -e
+# be verbose
+set -x
+
+for OS in centos7 opensuse-42.2
+do
+	echo
+	echo "Checking package build for ${OS} ...."
+	echo
+	buildlib/cbuild build-images ${OS}
+	buildlib/cbuild pkg ${OS}
+done
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/5] travis: Add RedHat and SuSE rpmbuild support

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 06:55:54PM +0200, Leon Romanovsky wrote:
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Provide a new script for testing rpmbuild under RedHat and SuSE
> environments which validates both of the suse/rdma-core.spec and
> redhat/rdma-core.spec specfiles.
> 
> The script performs the RPM package build test by utilizing the existing
> cbuild tool.

This breaks cbuild pkg travis - we should not attempt to build using
docker when run outside travis:

$ buildlib/cbuild pkg travis
[..]
+ for OS in centos7 opensuse-42.2 artful
+ echo
+ echo 'Checking package build for centos7 ....'
+ echo
+ buildlib/cbuild build-images centos7

Checking package build for centos7 ....

Traceback (most recent call last):
  File "buildlib/cbuild", line 54, in <module>
    import yaml
ImportError: No module named yaml
Traceback (most recent call last):
  File "buildlib/cbuild", line 802, in <module>
    args.func(args);
  File "buildlib/cbuild", line 631, in cmd_pkg
    run_travis_build(args,env);
  File "buildlib/cbuild", line 621, in run_travis_build
    docker_cmd(args,*opts);
  File "buildlib/cbuild", line 371, in docker_cmd
    return subprocess.check_call(["sudo","docker"] + cmd);
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', 'docker', 'run', '--read-only', '--rm=true', '-v', '/tmp/tmpxhYvXb:/home/travis/build', '-v', '/home/jgg/work/plumbing/.git:/home/travis/build/src/.git:ro', '-w', '/home/travis/build/src', '-u', '2009', '-e', 'TRAVIS_COMMIT_RANGE=41e755a28d97c1965f03b1c6ce6dd7b63def424d..HEAD', '-e', 'TRAVIS_BRANCH=41e755a28d97c1965f03b1c6ce6dd7b63def424d', '-e', 'TRAVIS_EVENT_TYPE=pull_request', '-e', 'HOME=/home/travis', '-e', 'TMPDIR=/home/travis/build/tmp', 'build-rdma-core/travis', '/bin/bash', '/home/travis/build/go.sh']' returned non-zero exit status 1

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/5] travis: Add RedHat and SuSE rpmbuild support

[Nicolas Morey-Chaisemartin]

Le 02/11/2017 à 18:31, Jason Gunthorpe a écrit :
> On Thu, Nov 02, 2017 at 06:55:54PM +0200, Leon Romanovsky wrote:
>> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Provide a new script for testing rpmbuild under RedHat and SuSE
>> environments which validates both of the suse/rdma-core.spec and
>> redhat/rdma-core.spec specfiles.
>>
>> The script performs the RPM package build test by utilizing the existing
>> cbuild tool.
> This breaks cbuild pkg travis - we should not attempt to build using
> docker when run outside travis:
I'm guessing you meant *in*side travis ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/5] travis: Add RedHat and SuSE rpmbuild support

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 06:34:08PM +0100, Nicolas Morey-Chaisemartin wrote:
> 
> 
> Le 02/11/2017 à 18:31, Jason Gunthorpe a écrit :
> > On Thu, Nov 02, 2017 at 06:55:54PM +0200, Leon Romanovsky wrote:
> >> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >>
> >> Provide a new script for testing rpmbuild under RedHat and SuSE
> >> environments which validates both of the suse/rdma-core.spec and
> >> redhat/rdma-core.spec specfiles.
> >>
> >> The script performs the RPM package build test by utilizing the existing
> >> cbuild tool.
> > This breaks cbuild pkg travis - we should not attempt to build using
> > docker when run outside travis:

> I'm guessing you meant *in*side travis ?

No, outside.. This point of these patches is to run docker inside the
travis environment, my comment that when not running under real travis
we should not try to invoke docker.

Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/5] travis: Add RedHat and SuSE rpmbuild support

[Alaa Hleihel]

On 02/11/2017 21:44, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 06:34:08PM +0100, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 02/11/2017 à 18:31, Jason Gunthorpe a écrit :
>>> On Thu, Nov 02, 2017 at 06:55:54PM +0200, Leon Romanovsky wrote:
>>>> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>>>
>>>> Provide a new script for testing rpmbuild under RedHat and SuSE
>>>> environments which validates both of the suse/rdma-core.spec and
>>>> redhat/rdma-core.spec specfiles.
>>>>
>>>> The script performs the RPM package build test by utilizing the existing
>>>> cbuild tool.
>>> This breaks cbuild pkg travis - we should not attempt to build using
>>> docker when run outside travis:
>> I'm guessing you meant *in*side travis ?
> No, outside.. This point of these patches is to run docker inside the
> travis environment, my comment that when not running under real travis
> we should not try to invoke docker.

Thanks Jason, I will fix it.

Regards,
Alaa

> Jason
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 4/5] buildlib/cbuild: Add Ubuntu artful

[Leon Romanovsky]

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

This patch adds Ubuntu17.10 artful, that comes with GCC 7

Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 buildlib/cbuild | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/buildlib/cbuild b/buildlib/cbuild
index 098bec9a..1ddc72c4 100755
--- a/buildlib/cbuild
+++ b/buildlib/cbuild
@@ -181,6 +181,12 @@ class xenial(APTEnvironment):
     name = "ubuntu-16.04";
     aliases = {"xenial"};

+class artful(APTEnvironment):
+    docker_parent = "ubuntu:17.10"
+    pkgs = xenial.pkgs
+    name = "ubuntu-17.10";
+    aliases = {"artful"};
+
 class jessie(APTEnvironment):
     docker_parent = "debian:8"
     pkgs = xenial.pkgs;
@@ -325,6 +331,7 @@ environments = [centos6(),
                 travis(),
                 trusty(),
                 xenial(),
+                artful(),
                 jessie(),
                 stretch(),
                 fc26(),
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Leon Romanovsky]

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

This will be compiled with GCC 7 coming with Ubuntu Artful

Signed-off-by: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 buildlib/package-build-test |  2 +-
 buildlib/travis-build       | 14 --------------
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/buildlib/package-build-test b/buildlib/package-build-test
index d767f61f..b9624b31 100755
--- a/buildlib/package-build-test
+++ b/buildlib/package-build-test
@@ -5,7 +5,7 @@ set -e
 # be verbose
 set -x

-for OS in centos7 opensuse-42.2
+for OS in centos7 opensuse-42.2 artful
 do
 	echo
 	echo "Checking package build for ${OS} ...."
diff --git a/buildlib/travis-build b/buildlib/travis-build
index bf86baa7..1a88dff2 100755
--- a/buildlib/travis-build
+++ b/buildlib/travis-build
@@ -45,17 +45,3 @@ rm CMakeCache.txt
 CC=clang-4.0 CFLAGS=-Werror cmake -GNinja ..
 ninja
 cp ../util/udma_barrier.h.old ../util/udma_barrier.h
-
-# Finally run through gcc-7 64 bit through the debian packaging This gives a
-# good clue if patches are changing packaging related things, the RPM stuff
-# will have to be audited by hand.
-
-# When running cmake through debian/rules it is hard to set -Werror,
-# instead force it on by changing the CMakeLists.txt
-cd ..
-echo 'set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")' >> buildlib/RDMA_EnableCStd.cmake
-sed -i -e 's/-DCMAKE_BUILD_TYPE=Release//g' debian/rules
-sed -i -e 's/ninja \(.*\)-v/ninja \1/g' debian/rules
-
-CC=gcc-7 debian/rules build
-fakeroot debian/rules binary
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> This will be compiled with GCC 7 coming with Ubuntu Artful

Hurm. This point of this is to test the latest gcc, not just the GCC
in a distro.

We should be testing gcc-8 here, but it isn't available for
trusty right now. :(

Then the lines:

      - ubuntu-toolchain-r-test

and

      - gcc-7

Should be removed from the .travis.yml as well in this patch.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

On Thu, Nov 02, 2017 at 11:05:54AM -0600, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
> > From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > This will be compiled with GCC 7 coming with Ubuntu Artful
>
> Hurm. This point of this is to test the latest gcc, not just the GCC
> in a distro.
>
> We should be testing gcc-8 here, but it isn't available for
> trusty right now. :(
>
> Then the lines:
>
>       - ubuntu-toolchain-r-test
>
> and
>
>       - gcc-7
>
> Should be removed from the .travis.yml as well in this patch.

It looks like we can remove debhelper too.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

On Thu, Nov 02, 2017 at 11:05:54AM -0600, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
> > From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > This will be compiled with GCC 7 coming with Ubuntu Artful
>
> Hurm. This point of this is to test the latest gcc, not just the GCC
> in a distro.
>
> We should be testing gcc-8 here, but it isn't available for
> trusty right now. :(
>
> Then the lines:
>
>       - ubuntu-toolchain-r-test
>
> and
>
>       - gcc-7
>
> Should be removed from the .travis.yml as well in this patch.

lib32gcc-7-dev depends on gcc-7 and it depends on
ubuntu-toolchain-r-test.

Thanks



>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 07:32:55PM +0200, Leon Romanovsky wrote:
> On Thu, Nov 02, 2017 at 11:05:54AM -0600, Jason Gunthorpe wrote:
> > On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
> > > From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >
> > > This will be compiled with GCC 7 coming with Ubuntu Artful
> >
> > Hurm. This point of this is to test the latest gcc, not just the GCC
> > in a distro.
> >
> > We should be testing gcc-8 here, but it isn't available for
> > trusty right now. :(
> >
> > Then the lines:
> >
> >       - ubuntu-toolchain-r-test
> >
> > and
> >
> >       - gcc-7
> >
> > Should be removed from the .travis.yml as well in this patch.
> 
> lib32gcc-7-dev depends on gcc-7 and it depends on
> ubuntu-toolchain-r-test.

We can probably use the 32 bit packages that come with trusty..

Arguably though it might be better to test with 32 bit gcc-latest..

Even better would be to do 32 bit test under docker where we could make
32 bit cross work 100% ..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Alaa Hleihel]

On 02/11/2017 19:55, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 07:32:55PM +0200, Leon Romanovsky wrote:
>> On Thu, Nov 02, 2017 at 11:05:54AM -0600, Jason Gunthorpe wrote:
>>> On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
>>>> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>>>
>>>> This will be compiled with GCC 7 coming with Ubuntu Artful
>>> Hurm. This point of this is to test the latest gcc, not just the GCC
>>> in a distro.
>>>
>>> We should be testing gcc-8 here, but it isn't available for
>>> trusty right now. :(
>>>
>>> Then the lines:
>>>
>>>       - ubuntu-toolchain-r-test
>>>
>>> and
>>>
>>>       - gcc-7
>>>
>>> Should be removed from the .travis.yml as well in this patch.
>> lib32gcc-7-dev depends on gcc-7 and it depends on
>> ubuntu-toolchain-r-test.
> We can probably use the 32 bit packages that come with trusty..

OK, I'll remove GCC-7 and deb helpers installations from travis.yml.

Regards,
Alaa

> Arguably though it might be better to test with 32 bit gcc-latest..
>
> Even better would be to do 32 bit test under docker where we could make
> 32 bit cross work 100% ..
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Alaa Hleihel]

On 05/11/2017 12:00, Alaa Hleihel wrote:
>
> On 02/11/2017 19:55, Jason Gunthorpe wrote:
>> On Thu, Nov 02, 2017 at 07:32:55PM +0200, Leon Romanovsky wrote:
>>> On Thu, Nov 02, 2017 at 11:05:54AM -0600, Jason Gunthorpe wrote:
>>>> On Thu, Nov 02, 2017 at 06:55:56PM +0200, Leon Romanovsky wrote:
>>>>> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>>>>
>>>>> This will be compiled with GCC 7 coming with Ubuntu Artful
>>>> Hurm. This point of this is to test the latest gcc, not just the GCC
>>>> in a distro.
>>>>
>>>> We should be testing gcc-8 here, but it isn't available for
>>>> trusty right now. :(
>>>>
>>>> Then the lines:
>>>>
>>>>       - ubuntu-toolchain-r-test
>>>>
>>>> and
>>>>
>>>>       - gcc-7
>>>>
>>>> Should be removed from the .travis.yml as well in this patch.
>>> lib32gcc-7-dev depends on gcc-7 and it depends on
>>> ubuntu-toolchain-r-test.
>> We can probably use the 32 bit packages that come with trusty..
> OK, I'll remove GCC-7 and deb helpers installations from travis.yml.
>
> Regards,
> Alaa

There are issues using the trusty 32 bit packages (I'm getting #error "SSE instruction set not enabled").
So, for now I will only cleanup the unnecessary deb helpers from travis.yml .


+cd ../build32
+CFLAGS='-Werror -m32'
+cmake -GNinja .. -DENABLE_RESOLVE_NEIGH=0
-- The C compiler identification is GNU 4.8.5
...
...
...
-- Build files have been written to: /home/travis/build/alaahl/rdma-core/build32
+ninja
[11/183] Building C object util/CMakeFiles/rdma_util.dir/mmio.c.o
FAILED: /usr/bin/gcc   -Werror -m32  -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter -Wmissing-prototypes -Wmissing-declarations -Wwrite-strings -Wformat=2 -Wshadow -Wno-missing-field-initializers -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -O2 -g  -Iinclude    -std=gnu11 -MMD -MT util/CMakeFiles/rdma_util.dir/mmio.c.o -MF util/CMakeFiles/rdma_util.dir/mmio.c.o.d -o util/CMakeFiles/rdma_util.dir/mmio.c.o   -c ../util/mmio.c
In file included from ../util/mmio.c:37:0:
/usr/lib/gcc/x86_64-linux-gnu/4.8/include/xmmintrin.h:31:3: error: #error "SSE instruction set not enabled"
 # error "SSE instruction set not enabled"
   ^
../util/mmio.c: In function ‘sse_mmio_write64_be’:
../util/mmio.c:45:2: error: unknown type name ‘__m128’
  __m128 tmp = {};
  ^
../util/mmio.c:45:2: error: empty scalar initializer
../util/mmio.c:45:2: error: (near initialization for ‘tmp’)
../util/mmio.c:46:2: error: implicit declaration of function ‘_mm_loadl_pi’ [-Werror=implicit-function-declaration]
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
  ^
../util/mmio.c:46:35: error: ‘__m64’ undeclared (first use in this function)
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
                                   ^
../util/mmio.c:46:35: note: each undeclared identifier is reported only once for each function it appears in
../util/mmio.c:46:42: error: expected expression before ‘)’ token
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
                                          ^
../util/mmio.c:47:2: error: implicit declaration of function ‘_mm_storel_pi’ [-Werror=implicit-function-declaration]
  _mm_storel_pi((__m64 *)addr,tmp);
  ^
../util/mmio.c:47:24: error: expected expression before ‘)’ token
  _mm_storel_pi((__m64 *)addr,tmp);
                        ^
cc1: all warnings being treated as errors
[11/183] Building C object util/CMakeFiles/rdma_util_pic.dir/mmio.c.o
FAILED: /usr/bin/gcc   -Werror -m32  -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter -Wmissing-prototypes -Wmissing-declarations -Wwrite-strings -Wformat=2 -Wshadow -Wno-missing-field-initializers -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -O2 -g  -fPIC -Iinclude    -std=gnu11 -MMD -MT util/CMakeFiles/rdma_util_pic.dir/mmio.c.o -MF util/CMakeFiles/rdma_util_pic.dir/mmio.c.o.d -o util/CMakeFiles/rdma_util_pic.dir/mmio.c.o   -c ../util/mmio.c
In file included from ../util/mmio.c:37:0:
/usr/lib/gcc/x86_64-linux-gnu/4.8/include/xmmintrin.h:31:3: error: #error "SSE instruction set not enabled"
 # error "SSE instruction set not enabled"
   ^
../util/mmio.c: In function ‘sse_mmio_write64_be’:
../util/mmio.c:45:2: error: unknown type name ‘__m128’
  __m128 tmp = {};
  ^
../util/mmio.c:45:2: error: empty scalar initializer
../util/mmio.c:45:2: error: (near initialization for ‘tmp’)
../util/mmio.c:46:2: error: implicit declaration of function ‘_mm_loadl_pi’ [-Werror=implicit-function-declaration]
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
  ^
../util/mmio.c:46:35: error: ‘__m64’ undeclared (first use in this function)
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
                                   ^
../util/mmio.c:46:35: note: each undeclared identifier is reported only once for each function it appears in
../util/mmio.c:46:42: error: expected expression before ‘)’ token
  tmp = _mm_loadl_pi(tmp, (__force __m64 *)&val);
                                          ^
../util/mmio.c:47:2: error: implicit declaration of function ‘_mm_storel_pi’ [-Werror=implicit-function-declaration]
  _mm_storel_pi((__m64 *)addr,tmp);
  ^
../util/mmio.c:47:24: error: expected expression before ‘)’ token
  _mm_storel_pi((__m64 *)addr,tmp);
                        ^
cc1: all warnings being treated as errors
[11/183] Building C object libibverbs/...keFiles/ibverbs_tools.dir/pingpong.c.o
ninja: build stopped: subcommand failed.



>> Arguably though it might be better to test with 32 bit gcc-latest..
>>
>> Even better would be to do 32 bit test under docker where we could make
>> 32 bit cross work 100% ..
>>
>> Jason
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 5/5] travis: Test Debian packaging under Artful container

[Jason Gunthorpe]

On Sun, Nov 05, 2017 at 03:30:01PM +0200, Alaa Hleihel wrote:

> There are issues using the trusty 32 bit packages (I'm getting
> #error "SSE instruction set not enabled").  So, for now I will only
> cleanup the unnecessary deb helpers from travis.yml .

Huh, that is a build bug in rdma-core.

Looks like this stuff in mmio.c should be protected by a #ifdef
__SSE__

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 0/5] Perform package tests in Travis CI

[Jason Gunthorpe]

On Thu, Nov 02, 2017 at 06:55:51PM +0200, Leon Romanovsky wrote:
> This patchset comes from Alaa and he adds to Travis CI ability
> to reuse our cbuild script to build various packages.
> 
> The PR is https://github.com/linux-rdma/rdma-core/pull/241

Not to say we shouldn't apply this PR, but if we go down this road
then we should also ultimately switch to circleci since it has actual
native support for docker and crucially support for docker image
caching.

With that each of the docker images could be run in parallel instead
of sequentially and it would resolve our general issues with having to
use the ancient trusty baseline that travis uses.

AFAIK the sticking point is that we need to have a public docker
container registry, preferably co-located with circle ci's build
workers..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 0/5] Perform package tests in Travis CI

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Thu, Nov 02, 2017 at 03:18:51PM -0600, Jason Gunthorpe wrote:
> On Thu, Nov 02, 2017 at 06:55:51PM +0200, Leon Romanovsky wrote:
> > This patchset comes from Alaa and he adds to Travis CI ability
> > to reuse our cbuild script to build various packages.
> >
> > The PR is https://github.com/linux-rdma/rdma-core/pull/241
>
> Not to say we shouldn't apply this PR, but if we go down this road
> then we should also ultimately switch to circleci since it has actual
> native support for docker and crucially support for docker image
> caching.

I think that we are pushing the rdma-core into that direction and it
is a matter of time when we will be there. As a first step we need to
polish this PR and merge it, after that we should convert all our tests
to run in containers, so the transition will be smooth.

>
> With that each of the docker images could be run in parallel instead
> of sequentially and it would resolve our general issues with having to
> use the ancient trusty baseline that travis uses.
>
> AFAIK the sticking point is that we need to have a public docker
> container registry, preferably co-located with circle ci's build
> workers..
>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]