From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 3/3] libhns: Fix endian format of payload and immediate Date: Sun, 5 Nov 2017 19:09:45 -0700 Message-ID: <20171106020945.GA26011@ziepe.ca> References: <1509530440-164400-1-git-send-email-oulijun@huawei.com> <1509530440-164400-4-git-send-email-oulijun@huawei.com> <20171101161328.GB7815@ziepe.ca> <20171104100846.GA1636@mtr-leonro.local> <7dba9ad9-5a71-c4fe-b2b9-ccc35c188f8c@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <7dba9ad9-5a71-c4fe-b2b9-ccc35c188f8c-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: oulijun Cc: Leon Romanovsky , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, Nov 06, 2017 at 09:43:05AM +0800, oulijun wrote: > 在 2017/11/4 18:08, Leon Romanovsky 写道: > > On Wed, Nov 01, 2017 at 10:13:28AM -0600, Jason Gunthorpe wrote: > >> On Wed, Nov 01, 2017 at 06:00:40PM +0800, Lijun Ou wrote: > >>> @@ -385,7 +385,7 @@ static int hns_roce_v2_poll_one(struct hns_roce_cq *cq, > >>> case HNS_ROCE_RECV_OP_RDMA_WRITE_IMM: > >>> wc->opcode = IBV_WC_RECV_RDMA_WITH_IMM; > >>> wc->wc_flags = IBV_WC_WITH_IMM; > >>> - wc->imm_data = cqe->rkey_immtdata; > >>> + wc->imm_data = be32toh(cqe->rkey_immtdata); > >>> break; > >> > >> This can't be right, wc->imm_data is marked be32. > > > > Lijun, > > > > Are you going to fix it? > > > > Thanks > > > Yes， I think that it is not fixed. I have tested the roce device > aginst hip08, D05(ARM64) and CX3, and I also have tested the D05 > aginst cx3 and D05. I also tried to run sparse and don't produce a > userful result. I also follow Jason's advice. Is it ok? The patch I sent fixes the bug properly, you need to review and validate it. You'll also need to get sparse to work, in the mean time use 'buildlib/cbuild pkg travis' which will run sparse on hns once you apply my patch. My patch fixes all the sparse problems. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html