From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Amrani,
Ram" <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
Yishai Hadas
<yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Elior,
Ariel" <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Kalderon,
Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Bodong Wang <bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-core] verbs: Do not block QP attr_masks used by older kernels
Date: Sun, 5 Nov 2017 19:28:18 -0700 [thread overview]
Message-ID: <20171106022818.GE26011@ziepe.ca> (raw)
In-Reply-To: <20171105071029.GC31774-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Sun, Nov 05, 2017 at 09:10:29AM +0200, Leon Romanovsky wrote:
> > @@ -909,6 +909,15 @@ enum ibv_qp_attr_mask {
> > IBV_QP_PATH_MIG_STATE = 1 << 18,
> > IBV_QP_CAP = 1 << 19,
> > IBV_QP_DEST_QPN = 1 << 20,
> > +#if 0
> > + /* These bits were supported on older kernels, but never exposed to
> > + * user space:
> > + */
> > + _IBV_QP_COMPAT1 = 1 << 21,
> > + _IBV_QP_COMPAT2 = 1 << 22,
> > + _IBV_QP_COMPAT3 = 1 << 23,
> > + _IBV_QP_COMPAT3 = 1 << 24,
> > +#endif
>
> Why do we need "if 0" in production code (global header file)?
It is really a comment. I don't want to introduce new global symbols
just for this, or loose the obvious formatting structure of the enum.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-06 2:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 21:50 [PATCH rdma-core] verbs: Do not block QP attr_masks used by older kernels Jason Gunthorpe
[not found] ` <20171102215031.GY18874-uk2M96/98Pc@public.gmane.org>
2017-11-05 7:10 ` Leon Romanovsky
[not found] ` <20171105071029.GC31774-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-06 2:28 ` Jason Gunthorpe [this message]
[not found] ` <20171106022818.GE26011-uk2M96/98Pc@public.gmane.org>
2017-11-06 5:20 ` Leon Romanovsky
2017-11-07 6:21 ` Amrani, Ram
[not found] ` <BN3PR07MB2578908EF39AF93B472208ADF8510-EldUQEzkDQfpW3VS/XPqkOFPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-11-09 13:24 ` Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106022818.GE26011@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox