public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH for-next 11/11] IB/hfi1: Handle initial value of 0 for CCTI setting
Date: Mon, 06 Nov 2017 06:39:29 -0800	[thread overview]
Message-ID: <20171106143927.27539.11851.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20171106143510.27539.65950.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>

When the driver is loaded it sets the default CCTI value to be 0. When the FM
starts and CCA is disabled the driver sets the max value to 65535 due the driver
subtracting 1 from 0 and the fact that the CCTI value is a u16.

Special case the subtraction to find the index for a 0 value.

Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/hfi1/mad.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c
index 1277e1c..cf8dba3 100644
--- a/drivers/infiniband/hw/hfi1/mad.c
+++ b/drivers/infiniband/hw/hfi1/mad.c
@@ -3701,7 +3701,11 @@ static void apply_cc_state(struct hfi1_pportdata *ppd)
 
 	*new_cc_state = *old_cc_state;
 
-	new_cc_state->cct.ccti_limit = ppd->total_cct_entry - 1;
+	if (ppd->total_cct_entry)
+		new_cc_state->cct.ccti_limit = ppd->total_cct_entry - 1;
+	else
+		new_cc_state->cct.ccti_limit = 0;
+
 	memcpy(new_cc_state->cct.entries, ppd->ccti_entries,
 	       ppd->total_cct_entry * sizeof(struct ib_cc_table_entry));
 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-06 14:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 14:38 [PATCH for-next 00/11] IB/hfi1: Driver fixes for 11/6/2017 Dennis Dalessandro
     [not found] ` <20171106143510.27539.65950.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-11-06 14:38   ` [PATCH for-next 01/11] IB/hfi1: Allow MgmtAllowed on B2B setups Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 02/11] IB/hfi1: Reduce 8051 command timeout Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 03/11] IB/hfi1: Remove wrapper function in mmu_rb Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 04/11] IB/hfi1: Fix a wrapping test to insure the correct timeout Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 05/11] IB/hfi1: Remove unnecessary if check Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 06/11] IB/hfi1: Do not allocate PIO send contexts for VNIC Dennis Dalessandro
2017-11-06 14:38   ` [PATCH for-next 07/11] IB/hfi1: Prohibit invalid Init to Armed state transition Dennis Dalessandro
2017-11-06 14:39   ` [PATCH for-next 08/11] IB/hfi1: Send 'reboot' as planned down remote reason Dennis Dalessandro
2017-11-06 14:39   ` [PATCH for-next 09/11] IB/core: Convert OPA AH to IB for Extended LIDs only Dennis Dalessandro
2017-11-06 14:39   ` [PATCH for-next 10/11] IB/hfi1: Mask upper 16Bits of Extended LID prior to rvt_cq_entry Dennis Dalessandro
2017-11-06 14:39   ` Dennis Dalessandro [this message]
2017-11-13 20:55   ` [PATCH for-next 00/11] IB/hfi1: Driver fixes for 11/6/2017 Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106143927.27539.11851.stgit@scvm10.sc.intel.com \
    --to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox