Re: [PATCH rdma-core v1 3/3] travis: Test Debian packaging under artful container

[Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>]

On Mon, Nov 06, 2017 at 10:19:37AM +0200, Alaa Hleihel wrote:
> 
> 
> On 06/11/2017 4:17, Jason Gunthorpe wrote:
> > On Sun, Nov 05, 2017 at 04:45:02PM +0200, Leon Romanovsky wrote:
> >
> >> -# Finally run through gcc-7 64 bit through the debian packaging This gives a
> >> -# good clue if patches are changing packaging related things, the RPM stuff
> >> -# will have to be audited by hand.
> >> -
> >> -# When running cmake through debian/rules it is hard to set -Werror,
> >> -# instead force it on by changing the CMakeLists.txt
> >> -cd ..
> >> -echo 'set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")' >> buildlib/RDMA_EnableCStd.cmake
> > Loosing this stuff seems like a problem though. We need to make sure
> > the package builds run with -Werror or travis will not flag new
> > warnings.
> 
> We still have compilation tests with -Werror in buildlib/travis-build (clang, 32 bit, arm, etc..).
> If that is not enough,

It is not enough. All compilation tests must be run with -Werror and
if you move the gcc-7 test then you have to keep the -Werror

> I think we can pass the -Werror to rpmbuild via CFLAGS environment variable:
> CFLAGS="-Werror" rpmbuild ............

If that works properly it would be fine.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html