From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core v1 3/3] travis: Test Debian packaging under artful container Date: Mon, 6 Nov 2017 09:50:25 -0700 Message-ID: <20171106165025.GF26011@ziepe.ca> References: <20171105144503.32709-1-leon@kernel.org> <20171105144503.32709-4-leon@kernel.org> <20171106021737.GC26011@ziepe.ca> <68f08161-0ecf-17f7-f0fc-bc18b66fc4fa@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <68f08161-0ecf-17f7-f0fc-bc18b66fc4fa-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alaa Hleihel Cc: Leon Romanovsky , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Benjamin Drung , Nicolas Morey-Chaisemartin , Alaa Hleihel List-Id: linux-rdma@vger.kernel.org On Mon, Nov 06, 2017 at 10:19:37AM +0200, Alaa Hleihel wrote: > > > On 06/11/2017 4:17, Jason Gunthorpe wrote: > > On Sun, Nov 05, 2017 at 04:45:02PM +0200, Leon Romanovsky wrote: > > > >> -# Finally run through gcc-7 64 bit through the debian packaging This gives a > >> -# good clue if patches are changing packaging related things, the RPM stuff > >> -# will have to be audited by hand. > >> - > >> -# When running cmake through debian/rules it is hard to set -Werror, > >> -# instead force it on by changing the CMakeLists.txt > >> -cd .. > >> -echo 'set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")' >> buildlib/RDMA_EnableCStd.cmake > > Loosing this stuff seems like a problem though. We need to make sure > > the package builds run with -Werror or travis will not flag new > > warnings. > > We still have compilation tests with -Werror in buildlib/travis-build (clang, 32 bit, arm, etc..). > If that is not enough, It is not enough. All compilation tests must be run with -Werror and if you move the gcc-7 test then you have to keep the -Werror > I think we can pass the -Werror to rpmbuild via CFLAGS environment variable: > CFLAGS="-Werror" rpmbuild ............ If that works properly it would be fine. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html