public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Somnath Kotur
	<somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 1/4] RDMA/bnxt_re: Add memory barriers when processing CQ/EQ entries
Date: Mon, 6 Nov 2017 10:19:25 -0700	[thread overview]
Message-ID: <20171106171925.GB18802@ziepe.ca> (raw)
In-Reply-To: <1509984452-18336-2-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

On Mon, Nov 06, 2017 at 08:07:29AM -0800, Selvin Xavier wrote:
> From: Somnath Kotur <somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> 
> The code determines if the next ring entry is valid before proceeding
> further to read the rest of the entry. The CPU can re-order and read
> the rest of the entry first, possibly reading a stale entry, if DMA
> of a new entry happens right after reading it.

Please make sure the bnxt user space stuff in rdma-core does not have the
same problem...

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-06 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 16:07 [PATCH 0/4] bnxt_re: Bug fixes Selvin Xavier
     [not found] ` <1509984452-18336-1-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-11-06 16:07   ` [PATCH 1/4] RDMA/bnxt_re: Add memory barriers when processing CQ/EQ entries Selvin Xavier
     [not found]     ` <1509984452-18336-2-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-11-06 17:19       ` Jason Gunthorpe [this message]
     [not found]         ` <20171106171925.GB18802-uk2M96/98Pc@public.gmane.org>
2017-11-06 18:03           ` Selvin Xavier
2017-11-06 16:07   ` [PATCH 2/4] RDMA/bnxt_re: Set QP state in case of response completion errors Selvin Xavier
2017-11-06 16:07   ` [PATCH 3/4] RDMA/bnxt_re: Flush CQ notification Work Queue before destroying QP Selvin Xavier
2017-11-06 16:07   ` [PATCH 4/4] RDMA/bnxt_re: synchronize poll_cq and req_notify_cq verbs Selvin Xavier
2017-11-13 20:55   ` [PATCH 0/4] bnxt_re: Bug fixes Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106171925.GB18802@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox