Re: [PATCH rdma-core 2/2] bnxt_re/lib: increament psn in case of 0 length packets

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Thu, Nov 09, 2017 at 04:10:58AM -0500, Devesh Sharma wrote:
> If application posts a 0 length packte, post send routine
> is skipping to increament the psn number. This will cause
> PSN number to go out of sync and evantually connection would
> terminate due to sequence error.
>
> post_send routine must increament the psn number by 1 even
> for zero length packets.

s/increament/increment in all places.

Thanks

>
> Signed-off-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
>  providers/bnxt_re/verbs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c
> index 4d9b044..9d4e02b 100644
> --- a/providers/bnxt_re/verbs.c
> +++ b/providers/bnxt_re/verbs.c
> @@ -1048,6 +1048,8 @@ static void bnxt_re_fill_psns(struct bnxt_re_qp *qp, struct bnxt_re_psns *psns,
>  		pkt_cnt = (len / qp->mtu);
>  		if (len % qp->mtu)
>  			pkt_cnt++;
> +		if (len == 0)
> +			pkt_cnt = 1;
>  		nxt_psn = ((qp->sq_psn + pkt_cnt) & BNXT_RE_PSNS_NPSN_MASK);
>  		psns->flg_npsn = htole32(nxt_psn);
>  		qp->sq_psn = nxt_psn;
> --
> 1.8.3.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]