From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: "Michael J. Ruhl"
<michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] ibacm: Calculate correct tv_nsec value in event_wait()
Date: Sat, 11 Nov 2017 09:26:10 -0700 [thread overview]
Message-ID: <20171111162610.GL17451@ziepe.ca> (raw)
In-Reply-To: <20171110222853.10387.81730.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
On Fri, Nov 10, 2017 at 05:29:02PM -0500, Michael J. Ruhl wrote:
> gettimeofday(&curtime, NULL);
Ugh, the use of gettimeofday for this kind of stuff is also a serious bug.
This needs to use clock_gettime(CLOCK_MONOTONIC) and
pthread_condattr_setclock(&attr, CLOCK_MONOTONIC);
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-11 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 22:28 [PATCH 0/3] ibacm: acmp retry issues Michael J. Ruhl
[not found] ` <20171110222658.10387.16845.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-10 22:28 ` [PATCH 1/3] ibacm: Fix an incorrect expiration check for the retry timer Michael J. Ruhl
2017-11-10 22:29 ` [PATCH 2/3] ibacm: Calculate correct tv_nsec value in event_wait() Michael J. Ruhl
[not found] ` <20171110222853.10387.81730.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-11 16:26 ` Jason Gunthorpe [this message]
[not found] ` <20171111162610.GL17451-uk2M96/98Pc@public.gmane.org>
2017-11-13 13:30 ` Ruhl, Michael J
2017-11-10 22:29 ` [PATCH 3/3] ibacm: Fix a retry loop calculation race condition Michael J. Ruhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171111162610.GL17451@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox