public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Benjamin Drung
	<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Nicolas Morey-Chaisemartin
	<NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH rdma-core 2/3] util/mmio.c: Fix compilation errors when __SSE__ is not set on 32 bit
Date: Mon, 13 Nov 2017 11:59:33 -0700	[thread overview]
Message-ID: <20171113185933.GB6918@ziepe.ca> (raw)
In-Reply-To: <20171113060806.27354-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Mon, Nov 13, 2017 at 08:08:05AM +0200, Leon Romanovsky wrote:
> From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> When building for 32 bit, the compilation may fail with the following
> errors in case that __SSE__ is not set:
> 
> In file included from ../util/mmio.c:37:0:
> /usr/lib/gcc/x86_64-linux-gnu/4.8/include/xmmintrin.h:31:3: error: #error "SSE instruction set not enabled"

Please do not apply this until we fix the root cause.

Debian and RH 32 bit builds should be built with SSE turned on, so
they may need some compiler options in their packaging files.

Otherwise all this code is totally useless.

Also, this condition should be a #warning print or some kind of cmake
failure as it is deeply undesired..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-13 18:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13  6:08 [PATCH rdma-core 0/3] Fixes and package improvement to Travis CI Leon Romanovsky
     [not found] ` <20171113060806.27354-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13  6:08   ` [PATCH rdma-core 1/3] Fix compilation warnings when NDEBUG is set Leon Romanovsky
2017-11-13  6:08   ` [PATCH rdma-core 2/3] util/mmio.c: Fix compilation errors when __SSE__ is not set on 32 bit Leon Romanovsky
     [not found]     ` <20171113060806.27354-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13 18:59       ` Jason Gunthorpe [this message]
2017-11-13  6:08   ` [PATCH rdma-core 3/3] travis: Test Debian packaging under artful container Leon Romanovsky
     [not found]     ` <20171113060806.27354-4-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13 19:02       ` Jason Gunthorpe
2017-11-13  9:55   ` [PATCH rdma-core 0/3] Fixes and package improvement to Travis CI Nicolas Morey-Chaisemartin
     [not found]     ` <65be5c4f-0127-78c7-db0c-f54c22884902-l3A5Bk7waGM@public.gmane.org>
2017-11-14 18:30       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113185933.GB6918@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org \
    --cc=alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox