Re: [RFC PATCH] RDMA/cma: Remove netlink interface of CMA statistics

Leon Romanovsky
2017-11-14T09:56:05Z

[-- Attachment #1: Type: text/plain, Size: 2783 bytes --]

On Tue, Nov 14, 2017 at 10:51:31AM +0200, Or Gerlitz wrote:
> On Tue, Nov 14, 2017 at 10:05 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >
> > On Mon, Nov 13, 2017 at 12:24:32PM -0700, Jason Gunthorpe wrote:
> > > On Mon, Nov 13, 2017 at 04:40:24PM +0200, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > > >
> > > > CMA statistics were exposed to users through netlink interface long time
> > > > ago, but it wasn't exposed using netlink extensibility approach. The
> > > > current implementation was based on struct and not attributes.
> > > >
> > > > Let's remove it, before anyone is actually start to use it and prevents us
> > > > to write it properly.
> > >
> > > You should describe why you think it is safe to remove a uAPI from the
> > > kernel in the commit message.. When was it introduced? Why was a uAPI
> > > added with no users??
> >
> > I didn't want to invest time before I actually see that it is possible.
> > The purpose of this RFC is to hear feedback and see if anyone cares enough
> > about that code.
> >
> > The code was introduced a long time ago [1]
>
>
> missing ref

http://linux-rdma.vger.kernel.narkive.com/EMsWPDF2/patch-v4-0-6-ib-netlink-interface-and-rdma-cm-exports

>
> >
> > as an attempt to provide netstat-like information. It had simple demo application, which didn't
> > work for me
>
>
>
> what didn't work exactly?

Started from compilation, continued to wrong data presented.
There is no need to carry 7-years old code, which no one cares about it.

>
> This is UAPI, if you want to remove it, make sure to provide a good
> replacement and see
> if/what is the upstream procedure for UAPI changes/removals,

So, are you going to fight removal of DECnet support from netdev?
https://patchwork.ozlabs.org/patch/837484/
It is going to break user experience of Debian and Ubuntu 9.10 lovers.
http://retrocmp.com/decnet/decnet-on-ubuntu-setup

> I guess there is such, sending
> email to a subsystem list doesn't seem enough to me.

Maybe for you it is not enough, for Linus it is enough and for other
subsystems which removed user visible changes is enough too.
https://patchwork.kernel.org/patch/9788849/
https://www.spinics.net/lists/linux-btrfs/msg66769.html

Thanks

>
>
> >
> > before I started to refactor ib_netlink.
> >
> > Also latest fixes from Parav in the actual callback implementation support
> > my feelings that the kernel part is broken too.
> >
> > Is it enough to proceed with the submission of actual patch?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]