Re: [RFC PATCH] RDMA/cma: Remove netlink interface of CMA statistics

Jason Gunthorpe
2017-11-20T19:41:52Z

On Thu, Nov 16, 2017 at 01:53:03PM +0200, Or Gerlitz wrote:
> On Wed, Nov 15, 2017 at 9:50 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> > But before that, you ignored my question asking what is broken in the
> > current code, please don't.
>
> > You can't come to someone's code say it's broken without providing the data
> > and ask to revert it.
>
> Doug, Jason,
>
> I have asked multiple times what is broken in the cma netlink code and
> no answer.
>
> Please suggest how to proceed with this patch, there's a claim there
> that the code
> which is removed has issues but no data is given.

Well, I would like to know the issues as well, as I've already said I
think they should be described in the commit message.

But also, at the RFC stage the onus is on other people, particularly
people that want to keep the feature, to explain where it is being
used and why..

We need to decide if we drop the RFC and fix the implementation, apply
the the RFC, or add a deprecation printk warning, or something..

Please try to be productive here and concentrate on adding information
and not nit-picking the process! We all know removing a uapi is a big
deal.

Jason