public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Nicolas Morey-Chaisemartin
	<NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core 1/2] buildlib: use cmake to find python
Date: Mon, 13 Nov 2017 12:31:39 -0700	[thread overview]
Message-ID: <20171113193139.GN6918@ziepe.ca> (raw)
In-Reply-To: <1923c475-0597-a597-36a5-8a33cccae6ef-l3A5Bk7waGM@public.gmane.org>

On Mon, Nov 13, 2017 at 02:00:15PM +0100, Nicolas Morey-Chaisemartin wrote:
> Depending on the system, python might not be available as pythomn (but python2, python3, etc.)
> Use FIND_PACKAGE to get the right executable.

Looks fine to me.

>    # Compute a relative symlink from VERBS_PROVIDER_DIR to LIBDIR
> -  execute_process(COMMAND python ${CMAKE_SOURCE_DIR}/buildlib/relpath
> +  execute_process(COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/buildlib/relpath

I'm assuming this little script works with python3 ?

cbuild won't though..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-13 19:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 13:00 [PATCH rdma-core 1/2] buildlib: use cmake to find python Nicolas Morey-Chaisemartin
     [not found] ` <1923c475-0597-a597-36a5-8a33cccae6ef-l3A5Bk7waGM@public.gmane.org>
2017-11-13 13:33   ` Benjamin Drung
     [not found]     ` <1510580030.4026.10.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-11-13 13:35       ` Nicolas Morey-Chaisemartin
2017-11-13 19:31   ` Jason Gunthorpe [this message]
     [not found]     ` <20171113193139.GN6918-uk2M96/98Pc@public.gmane.org>
2017-11-13 19:56       ` Nicolas Morey-Chaisemartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113193139.GN6918@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox